add MultiManager to h5pyd __init__.py #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
reviewed
Apr 23, 2024
| """ | ||
| Get filepath for a test case given a testname | ||
| """ | ||
|
|
||
| # Just call the external function | ||
| filename = getTestFileName(basename, subfolder=subfolder) |
There was a problem hiding this comment.
getFileName invokes getTestFileName, but then overwrites the result to redo the same work.
There was a problem hiding this comment.
I made the change so getTestFileName can be invoked outside the TestCase class, but forgot to remove the duplicate code. Fixed now.
mattjala
reviewed
Apr 23, 2024
test/hl/multi_benchmark.py
Outdated
|
|
||
| for i in range(count): | ||
| filename = getTestFileName(f"bm_{i:04d}", subfolder="multi_bm") | ||
| f = h5py.File(filename, mode='w') |
There was a problem hiding this comment.
If the user hasn't specifically created the multi_bm, this will fail. We should either create that here or check for its existence to throw a helpful error
There was a problem hiding this comment.
updated to print message on IOError.
|
Looks good aside from my comments |
mattjala
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make MultiManager visible in base h5pyd.
Add log handler to MultiManager
Use env variable to set location of multi_benchmark.py output domains.