fix: properly split jsonl upload at lineends #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#123 introduced a broken behavior of uploading jsonl files, because lines would not be split at line endings anymore, but after exactly 1000 characters. See #136. This was done in a broader context of moving file I/O into or out of the event loop. I am not sure, why the original change was introduced. So, I think, my PR might probably be a workaround rather than a comprehensive fix. Maybe @dgomes can comment/review? |
fvanroie
approved these changes
Aug 6, 2024
|
Thanks! |
|
If the problem is the one identified in #136 then yes... Just not sure about the identified problem is the correct one :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #136