Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with OpenAL Soft 1.20 #612

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Conversation

zrax
Copy link
Member

@zrax zrax commented Jan 6, 2020

OpenAL Soft 1.20 changed the ALCdevice and ALCcontext typedefs.

Since the <alc.h> header is very small and does not include any other headers, we can just include it directly where necessary instead of trying to forward-declare the types.

@zrax
Copy link
Member Author

zrax commented Jan 6, 2020

Note: This will conflict with #596.

Since the <alc.h> header is very small and does not include any other
headers, we can just include it directly where necessary instead of
trying to forward-declare the types.
@Hoikas
Copy link
Member

Hoikas commented Jan 16, 2020

The conflict with #596 can be resolved easily, I think. I'd say go ahead and merge this.

@zrax zrax merged commit 5b855c8 into H-uru:master Jan 16, 2020
@zrax zrax deleted the alsoft_120 branch January 16, 2020 03:16
@Hoikas Hoikas mentioned this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants