Key Map dialog improvements. #1573
Conversation
Previously, it was possible to get the key map chronicle into an invalid state with the same key bound to multiple controls. You can reproduce that by binding UpArrow to "start chat" then rebinding UpArrow to "move forward". The chronicle will then have two entries for UpArrow in it. The bindings will behave as you expect until you quit and restart Uru, at which point UpArrow will be bound to "start chat" again. The only way to fix this is by resetting the key map to default. To fix this, I cleaned up the code to make the ownership of the key map more clear. Previously, the code half-handedly updated the vault chronicle value and the key map. Now, we bind any input directly, and completely rewrite the chronicle each time a key is bound. In this way, the UI display, key bindings, and key chronicle all have a single source of truth. This also includes general code cleanups, modernizing the Python. For example, we can now rely on the key dictionary being stored in the same order that it's initialized.
This entry in the key conversion LUT is hiding the expected value of "(unmapped)". I fixed the captialization to match the other localizations.
This is useful if you want to remove the "start chat" binding.
| # force writing the keymap | ||
| km.writeKeyMap() |
There was a problem hiding this comment.
The new version no longer calls km.writeKeyMap() anywhere. I assume this is intentional?
Perhaps we should just remove ptKeyMap.writeKeyMap and the underlying plInputInterfaceMgr::WriteKeyMap(). AFACIT that code did nothing useful anyway. It tries to write a file init/keyboard.fni, but MOULa installs normally don't have an init folder, so that always fails silently.
There was a problem hiding this comment.
Right, I intentionally removed this call because it has no effect. I didn't want to remove the writeKeyMap code in this PR, though.
I always forget that Americans don't have that extra key next to the left Shift key that Uru interprets as
I don't think so. That PR mainly implements something different, namely saving the key map to a local config file (in a way that actually works, unlike |
Co-authored-by: dgelessus <[email protected]>
|
Out of scope for this PR, but there's an open question around how to handle internationalization of keymaps particularly across different keyboard layouts when targeting non-Windows environments: #786 (mostly linking this to hopefully get some more thoughts in that discussion) |
Previously, it was possible to get the key map chronicle into an invalid state with the same key bound to multiple controls. You can reproduce that by binding UpArrow to "start chat" then rebinding UpArrow to "move forward". The chronicle will then have two entries for UpArrow in it. The bindings will behave as you expect until you quit and restart Uru, at which point UpArrow will be bound to "start chat" again. The only way to fix this is by resetting the key map to default.
To fix this, I cleaned up the code to make the ownership of the key map more clear. Previously, the code half-handedly updated the vault chronicle value and the key map. Now, we bind any input directly, and completely rewrite the chronicle each time a key is bound. In this way, the UI display, key bindings, and key chronicle all have a single source of truth.
Further, you can now unbind keys by pressing the current key binding. This is useful if, for example, you don't want "start chat" to be bound to anything. Previously, you would have needed to bind the "start chat" key to some other control, then bind that other control to what you actually wanted.
With this fixing the major keymap bugs and gotchas, we could probably close #1067.