Add support for new DynamicCamMap checkbox. #1572
Conversation
| @@ -827,6 +827,10 @@ def PtStartScreenCapture(selfKey,width=800,height=600): | |||
| """Starts a capture of the screen""" | |||
| pass | |||
|
|
|||
| def PtSupportsPlanarReflections() -> bool: | |||
| """Returns if planar reflections are supported""" | |||
| ... | |||
There was a problem hiding this comment.
For consistency with the rest of the file, and because this isn't a .pyi file:
| ... | |
| pass |
There was a problem hiding this comment.
This is the way that I've been doing all the rest of the new/updated API functions to ease the (eventual? hopeful?) transition to pyi. Example:
Plasma/Scripts/Python/plasma/Plasma.py
Lines 879 to 883 in 5807230
There was a problem hiding this comment.
Ah, alright then - I guess I never noticed any of those yet. Yes, it would be nice to convert these to proper .pyi files at some point.
| @@ -62,9 +62,10 @@ | |||
| kGraphicsShadows = "Graphics.Shadow.Enable" | |||
| kGraphicsVerticalSync = "Graphics.EnableVSync" | |||
| kGraphicsShadowQuality = "Graphics.Shadow.VisibleDistance" | |||
| kGraphicsDynamicReflections = "Graphics.EnablePlanarReflections" | |||
There was a problem hiding this comment.
For anyone else wondering: this console command has already existed since forever.
This has been fixed in xKIGUI.max. If you don't have the updated PRPs, the options menu will still work, it'll just be in English. Update your doggone PRPs, yo.
Myst V didn't have this function either. That's interesting because, in theory, we may be presented with a video card that doesn't support the Direct3D caps needed to perform the effect. At this stage in the game, everyone should support DCMs, so this is just an exercise in technical correctness.
Hoikas
force-pushed
the
options_menu_work
branch
from
401ea7c to
4fa0340
Compare
|
There seems to be a problem in the key map dialog where none of the key bindings are displaying. Investigating... |
The call to show the key binding text was obscured by all of the manual localization. Readd it.
|
Key bindings dialog is now working correctly. |
This is the companion piece to H-uru/moul-assets#251. There is no longer any need to manually localize the options menu 🎉. I didn't bother with improving the quality of tangential Python code. All of the options menu Python is terrible, and I didn't want to get bogged down with that.