Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimise suboptimal code #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

optimise suboptimal code #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 41 additions & 51 deletions script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,60 +1,50 @@
$(document).ready(function() {
var table = $('#scroll-table');
var originalTableBody = table.find('tbody').first();
var clonedTableBody = originalTableBody.clone();
var divider = $('<div class="divider"></div>');
table.append(clonedTableBody);
table.append(divider);
document.addEventListener('DOMContentLoaded', function() {

function isPositionStickySupported() {
var testElement = document.createElement('div');
testElement.style.position = 'sticky';
return testElement.style.position === 'sticky';
}

if (isPositionStickySupported()) {
console.log('position: sticky is supported');
// Add a class or perform some action
} else {
console.log('position: sticky is not supported');
// Fallback or other actions
}

var scrollSpeed = 1;
var scrollInterval = 65;
//
// setInterval(function () {
// var scrollTop = table.scrollTop();
// var scrollHeight = table.prop('scrollHeight');
// var visibleHeight = table.height();
//
// // Check if the scroll has reached near the end of the cloned table body
// if (scrollTop + visibleHeight >= scrollHeight - 20) {
var newClonedBody = originalTableBody.clone();
var newDivider = divider.clone();
table.append(newClonedBody);
table.append(newDivider);
// }
//
// table.animate()
//
// }, scrollInterval);
let counter = 1;
function FilipStupid() {
table.animate({
scrollTop: table.height() * (counter++)
}, 40000, 'linear', () => {
var newClonedBody = originalTableBody.clone();
var newDivider = divider.clone();
table.append(newClonedBody);
table.append(newDivider);
console.log("added new element")
});
FilipStupid();
var table = document.getElementById('scroll-table');
var originalTableBody = table.querySelector('tbody');
var divider = document.createElement('div');
divider.className = 'divider';

function _scroll() {
// Determine the height of the first cell in the table header
var rect = table.querySelector('thead tr').children[0].getBoundingClientRect();
var topElement = document.elementFromPoint(rect.left + 1, rect.bottom + 1);
var scrollAmount = topElement.getBoundingClientRect();
var backupScrollTop = table.scrollTop;
table.scrollTop += scrollAmount.height;

// console.log(scrollAmount.height);
// Check if the table has reached the bottom
if (table.scrollTop >= table.scrollHeight - table.clientHeight) {
table.scrollTop = backupScrollTop;
// Clone the original table body and append it to the table
var newClonedBody = originalTableBody.cloneNode(true);
table.appendChild(newClonedBody);
}
Comment on lines +22 to +37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the variable declaration to the top of the function to improve clarity and adhere to best practices.

- function _scroll() {
+ function _scroll() {
+    var newClonedBody;
     // Determine the height of the first cell in the table header
     var rect = table.querySelector('thead tr').children[0].getBoundingClientRect();
     var topElement = document.elementFromPoint(rect.left + 1, rect.bottom + 1);
     var scrollAmount = topElement.getBoundingClientRect();
     var backupScrollTop = table.scrollTop;
     table.scrollTop += scrollAmount.height;

     // console.log(scrollAmount.height);
     // Check if the table has reached the bottom
     if (table.scrollTop >= table.scrollHeight - table.clientHeight) {
         table.scrollTop = backupScrollTop;
         // Clone the original table body and append it to the table
-        var newClonedBody = originalTableBody.cloneNode(true);
+        newClonedBody = originalTableBody.cloneNode(true);
         table.appendChild(newClonedBody);
     }
 }
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
function _scroll() {
// Determine the height of the first cell in the table header
var rect = table.querySelector('thead tr').children[0].getBoundingClientRect();
var topElement = document.elementFromPoint(rect.left + 1, rect.bottom + 1);
var scrollAmount = topElement.getBoundingClientRect();
var backupScrollTop = table.scrollTop;
table.scrollTop += scrollAmount.height;
// console.log(scrollAmount.height);
// Check if the table has reached the bottom
if (table.scrollTop >= table.scrollHeight - table.clientHeight) {
table.scrollTop = backupScrollTop;
// Clone the original table body and append it to the table
var newClonedBody = originalTableBody.cloneNode(true);
table.appendChild(newClonedBody);
}
function _scroll() {
var newClonedBody;
// Determine the height of the first cell in the table header
var rect = table.querySelector('thead tr').children[0].getBoundingClientRect();
var topElement = document.elementFromPoint(rect.left + 1, rect.bottom + 1);
var scrollAmount = topElement.getBoundingClientRect();
var backupScrollTop = table.scrollTop;
table.scrollTop += scrollAmount.height;
// console.log(scrollAmount.height);
// Check if the table has reached the bottom
if (table.scrollTop >= table.scrollHeight - table.clientHeight) {
table.scrollTop = backupScrollTop;
// Clone the original table body and append it to the table
newClonedBody = originalTableBody.cloneNode(true);
table.appendChild(newClonedBody);
}
}
Tools
Biome

[error] 35-35: This var should be declared at the root of the enclosing function. (lint/correctness/noInnerDeclarations)

The var is accessible in the whole body of the enclosing function.
To avoid confusion, it should be declared at the root of the enclosing function.

}
FilipStupid();

function startScroll() {
_scroll(); // Initial scroll
setInterval(_scroll, 5000); // Set interval for periodic scrolling
}

// Call startScroll() to initiate scrolling
startScroll();
});
Comment on lines +1 to 47
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert function expression to arrow function for cleaner syntax.

- document.addEventListener('DOMContentLoaded', function() {
+ document.addEventListener('DOMContentLoaded', () => {
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
document.addEventListener('DOMContentLoaded', function() {
function isPositionStickySupported() {
var testElement = document.createElement('div');
testElement.style.position = 'sticky';
return testElement.style.position === 'sticky';
}
if (isPositionStickySupported()) {
console.log('position: sticky is supported');
// Add a class or perform some action
} else {
console.log('position: sticky is not supported');
// Fallback or other actions
}
var scrollSpeed = 1;
var scrollInterval = 65;
//
// setInterval(function () {
// var scrollTop = table.scrollTop();
// var scrollHeight = table.prop('scrollHeight');
// var visibleHeight = table.height();
//
// // Check if the scroll has reached near the end of the cloned table body
// if (scrollTop + visibleHeight >= scrollHeight - 20) {
var newClonedBody = originalTableBody.clone();
var newDivider = divider.clone();
table.append(newClonedBody);
table.append(newDivider);
// }
//
// table.animate()
//
// }, scrollInterval);
let counter = 1;
function FilipStupid() {
table.animate({
scrollTop: table.height() * (counter++)
}, 40000, 'linear', () => {
var newClonedBody = originalTableBody.clone();
var newDivider = divider.clone();
table.append(newClonedBody);
table.append(newDivider);
console.log("added new element")
});
FilipStupid();
var table = document.getElementById('scroll-table');
var originalTableBody = table.querySelector('tbody');
var divider = document.createElement('div');
divider.className = 'divider';
function _scroll() {
// Determine the height of the first cell in the table header
var rect = table.querySelector('thead tr').children[0].getBoundingClientRect();
var topElement = document.elementFromPoint(rect.left + 1, rect.bottom + 1);
var scrollAmount = topElement.getBoundingClientRect();
var backupScrollTop = table.scrollTop;
table.scrollTop += scrollAmount.height;
// console.log(scrollAmount.height);
// Check if the table has reached the bottom
if (table.scrollTop >= table.scrollHeight - table.clientHeight) {
table.scrollTop = backupScrollTop;
// Clone the original table body and append it to the table
var newClonedBody = originalTableBody.cloneNode(true);
table.appendChild(newClonedBody);
}
}
FilipStupid();
function startScroll() {
_scroll(); // Initial scroll
setInterval(_scroll, 5000); // Set interval for periodic scrolling
}
// Call startScroll() to initiate scrolling
startScroll();
});
document.addEventListener('DOMContentLoaded', () => {
function isPositionStickySupported() {
var testElement = document.createElement('div');
testElement.style.position = 'sticky';
return testElement.style.position === 'sticky';
}
if (isPositionStickySupported()) {
console.log('position: sticky is supported');
// Add a class or perform some action
} else {
console.log('position: sticky is not supported');
// Fallback or other actions
}
var table = document.getElementById('scroll-table');
var originalTableBody = table.querySelector('tbody');
var divider = document.createElement('div');
divider.className = 'divider';
function _scroll() {
// Determine the height of the first cell in the table header
var rect = table.querySelector('thead tr').children[0].getBoundingClientRect();
var topElement = document.elementFromPoint(rect.left + 1, rect.bottom + 1);
var scrollAmount = topElement.getBoundingClientRect();
var backupScrollTop = table.scrollTop;
table.scrollTop += scrollAmount.height;
// console.log(scrollAmount.height);
// Check if the table has reached the bottom
if (table.scrollTop >= table.scrollHeight - table.clientHeight) {
table.scrollTop = backupScrollTop;
// Clone the original table body and append it to the table
var newClonedBody = originalTableBody.cloneNode(true);
table.appendChild(newClonedBody);
}
}
function startScroll() {
_scroll(); // Initial scroll
setInterval(_scroll, 5000); // Set interval for periodic scrolling
}
// Call startScroll() to initiate scrolling
startScroll();
});
Tools
Biome

[error] 35-35: This var should be declared at the root of the enclosing function. (lint/correctness/noInnerDeclarations)

The var is accessible in the whole body of the enclosing function.
To avoid confusion, it should be declared at the root of the enclosing function.

[error] 1-47: This function expression can be turned into an arrow function. (lint/complexity/useArrowFunction)

Function expressions that don't use this can be turned into arrow functions.
Safe fix: Use an arrow function instead.


function isPositionStickySupported() {
var testElement = document.createElement('div');
testElement.style.position = 'sticky';
return testElement.style.position === 'sticky';
}

if (isPositionStickySupported()) {
console.log('position: sticky is supported');
// Add a class or perform some action
} else {
console.log('position: sticky is not supported');
// Fallback or other actions
}