[WebSocket + 네이버 클로바 챗봇] 경제 용어 챗봇 구현해보기 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.gradle.kts # src/main/resources/application.properties # src/main/resources/application.yml
stopmin
reviewed
Jul 9, 2024
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(ChatController.class); | ||
|
|
||
| private static String secretKey = "SnNOQ2ZPcElzYnJiTURtWUZXWFVnTUhqVEVQaVROWEU="; |
There was a problem hiding this comment.
키값 올려둔거 application-secret.yml파일로 빼주세요 ^^..
| private static final Logger logger = LoggerFactory.getLogger(ChatController.class); | ||
|
|
||
| private static String secretKey = "SnNOQ2ZPcElzYnJiTURtWUZXWFVnTUhqVEVQaVROWEU="; | ||
| private static String apiUrl = "https://v72bqnhpzy.apigw.ntruss.com/custom/v1/15050/eddd8440e74fa955e718cb3d1d76e68be523ad9293e60321542d50432f0e5255"; |
| logger.info("Request Message: {}", message); | ||
| logger.info("Signature: {}", encodeBase64String); | ||
|
|
||
| //api서버 접속 (서버 -> 서버 통신) |
There was a problem hiding this comment.
테스트코드라고 생각하겠습니다!! 가독성도 떨어지고 무슨 일을 하고 있는지 알기가 어렵네요 ㅠㅠ... 또한 컨트롤러에 있으면 안될 것 같은 로직들이 많은 것 같아요! 제대로 분리 부탁드립니다.
|
|
||
| //api서버 접속 (서버 -> 서버 통신) | ||
| HttpURLConnection con = (HttpURLConnection)url.openConnection(); | ||
| con.setRequestMethod("POST"); |
There was a problem hiding this comment.
HttpURLConnection을 쓰지 않아도 되는 것으로 아는데 이거는 왜 사용하신건가요?
| String jsonString = ""; | ||
| if(responseCode == 200) { // 정상 호출 | ||
|
|
||
| BufferedReader in = new BufferedReader( |
There was a problem hiding this comment.
BufferedReader는 응답을 읽는 용인 것인가요?
| //받아온 값을 세팅하는 부분 | ||
| JSONParser jsonparser = new JSONParser(); | ||
| try { | ||
| JSONObject json = (JSONObject)jsonparser.parse(jsonString); |
| String description = ""; | ||
| description = (String)data.get("description"); | ||
| chatMessage = description; | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
에러 핸들링이 제대로 안된 것 같습니다! 전역적으로 잡는 행위는 지양하는게 좋을 것 같습니다. 그리고 웹소캣은 websocket별도의 에러가 있는 것으로 알고있습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?