마을 기사 읽기 페이지 UI작업 #107
Merged
마을 기사 읽기 페이지 UI작업 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yeonddori
reviewed
Jul 21, 2024
src/components/Headline.tsx
Outdated
| viewCount: number; | ||
| source: string; | ||
| uploadDate?: string; | ||
| viewCount?: number; |
There was a problem hiding this comment.
혹시 uploadDate와 viewCount가 마을에서는 필수가 아닌가요?!
필수라고 생각했어서 여쭤봅니다~!~!
There was a problem hiding this comment.
흠흠쓰 필수로 하겠습니다!! 어제 새벽에 짜서 ㅋㅋㅋㅋㅋ 약간 좀잡을 수 없네요
src/app/village/[id]/page.tsx
Outdated
Comment on lines
50
to
52
| <Box sx={{ marginTop: -2 }}> | ||
| <KakaoMap villages={[village]} /> | ||
| </Box> |
There was a problem hiding this comment.
혹시 지도 크기도 기사 너비에 맞게 줄이는 것에 대해 어떻게 생각하시나요~~?
너무 혼자 난 지도야!!! 소리치는 느낌이네요😂
대충 이런..? 근데 너무 휑한 것 같기도 하네요 ㅋㅋㅋ 디자인 너무 어렵습니다..
There was a problem hiding this comment.
흠흠쓰... 일단 한번 수정해보고 판단하개보겠습니다!!!!
src/app/village/[id]/page.tsx
Outdated
| import hiddenGems from '@/mocks/villages'; | ||
|
|
||
| const Page = async ({ params }: { params: { id: number } }) => { | ||
| const village = hiddenGems[params.id]; |
There was a problem hiding this comment.
데이터가 id는 1부터 시작인데 배열 형태로 쓰셔서 인덱스가 이상하게 잡히네요!
hiddenGems[params.id - 1] 해주셔야 될 것 같아요~!
yeonddori
approved these changes
Jul 21, 2024
src/app/village/[id]/page.tsx
Outdated
| import color from '@/constants/color'; | ||
| import hiddenGems from '@/mocks/villages'; | ||
|
|
||
| const Page = async ({ params }: { params: { id: number } }) => { |
There was a problem hiding this comment.
Client components cannot be async functions. 라고 합니다!!
async 빼주세요~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 요약
작업 상세 설명
리뷰 요구 사항
미리 보기