사라지는 마을 UI 작업 #101
Merged
사라지는 마을 UI 작업 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- 하.. 린트 너무 싫어 #98
- 하.. 린트 너무 싫어 #98
- 하.. 린트 너무 싫어 #98
yeonddori
approved these changes
Jul 20, 2024
src/app/village/page.tsx
Outdated
| @@ -0,0 +1,160 @@ | |||
| /* eslint-disable react-hooks/exhaustive-deps */ | |||
There was a problem hiding this comment.
빌드 실패 해결하면서 다 고쳐진 것 같은데 지워주세용~
src/components/KakaoMapComponent.tsx
Outdated
| villages: Village[]; | ||
| } | ||
|
|
||
| const KakaoMapComponent: React.FC<KakaoMapComponentProps> = ({ villages }) => { |
There was a problem hiding this comment.
파일 이름에 Component는 빼주십쇼!
React.FC는 지양하는 게 좋아서 이렇게 써주세용~!~!
const KakaoMap = ({ villages }: KakaoMapProps) => {- Props 수정 - React.FC 삭제 #98
- lint 이자식 #98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 요약
작업 상세 설명
리뷰 요구 사항
미리 보기
Screen.Recording.2024-07-21.at.4.22.03.AM.mov