Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detector improvements for v1 #148

Draft
wants to merge 42 commits into
base: v1
Choose a base branch
from
Draft

Conversation

Gum-Joe
Copy link
Owner

@Gum-Joe Gum-Joe commented Dec 5, 2020

Adds detector improvements and upgrades for v1 and so that it is compatible with v1.
Full task list in ClickUp.

@Gum-Joe Gum-Joe requested a review from ILikeTeaALot December 5, 2020 23:42
@Gum-Joe Gum-Joe added detector v1 Features and issues for v1 labels Dec 5, 2020
@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #148 (b3e638b) into v1 (65797ba) will decrease coverage by 62.57%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               v1     #148       +/-   ##
===========================================
- Coverage   93.25%   30.67%   -62.58%     
===========================================
  Files          68       15       -53     
  Lines        1883      251     -1632     
  Branches      247       28      -219     
===========================================
- Hits         1756       77     -1679     
- Misses        127      174       +47     
Impacted Files Coverage Δ
packages/@twokeys/common-hi/src/util/errors.ts 0.00% <0.00%> (-100.00%) ⬇️
...ckages/@twokeys/common-hi/src/setup/util/native.ts 0.00% <0.00%> (-100.00%) ⬇️
...ges/@twokeys/common-hi/src/setup/util/constants.ts 0.00% <0.00%> (-100.00%) ⬇️
...s/@twokeys/common-hi/src/setup/commands/project.ts 0.00% <0.00%> (-100.00%) ⬇️
...twokeys/common-hi/src/setup/commands/new-client.ts 0.00% <0.00%> (-100.00%) ⬇️
...s/common-hi/src/util/get-common-hi-asserts-root.ts 0.00% <0.00%> (-100.00%) ⬇️
...ages/@twokeys/common-hi/src/setup/commands/oobe.ts 0.00% <0.00%> (-91.67%) ⬇️
...ckages/@twokeys/common-hi/src/common/is-command.ts 16.66% <0.00%> (-83.34%) ⬇️
...s/@twokeys/common-hi/src/common/command-factory.ts 20.00% <0.00%> (-80.00%) ⬇️
...es/@twokeys/common-hi/src/setup/commands/daemon.ts 0.00% <0.00%> (-72.00%) ⬇️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65797ba...b3e638b. Read the comment docs.

@Gum-Joe Gum-Joe marked this pull request as draft December 5, 2020 23:44
This way we can install it.
Need to move to developing on a physical device/VM now.
Upgrade configs to allow mutiple /dev/input paths for one keyboard.
This is because evdev supports watching mutliple devices at once, and some devices need this.
Add pydoc to functions in watch_keyboard
Helps with #5
Fix issue where YAML import in config would be browser version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detector v1 Features and issues for v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant