-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detector improvements for v1 #148
Draft
Gum-Joe
wants to merge
42
commits into
v1
Choose a base branch
from
v1.0.0-detector-improvements-1
base: v1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add schema for provisioning config.
Codecov Report
@@ Coverage Diff @@
## v1 #148 +/- ##
===========================================
- Coverage 93.25% 30.67% -62.58%
===========================================
Files 68 15 -53
Lines 1883 251 -1632
Branches 247 28 -219
===========================================
- Hits 1756 77 -1679
- Misses 127 174 +47
Continue to review full report at Codecov.
|
…Keys into v1.0.0-detector-improvements-1
Add required properties to provision schema.
Add example
Rename client to example Change maps to strings to objects, instead of strings to strings.
Add tests for this
Add provisioning to provision
Rebuild schemas
This way we can install it.
Need to move to developing on a physical device/VM now.
Upgrade configs to allow mutiple /dev/input paths for one keyboard. This is because evdev supports watching mutliple devices at once, and some devices need this.
…Keys into v1.0.0-detector-improvements-1
Add pydoc to functions in watch_keyboard Helps with #5
Fix issue where YAML import in config would be browser version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds detector improvements and upgrades for v1 and so that it is compatible with v1.
Full task list in ClickUp.