Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing CPU brands for iPhone and iPad #1428

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

GuillaumeGomez
Copy link
Owner

Fixes #1386.

@dionysuzx: Can you confirm it improves your situation please?

@dionysuzx
Copy link
Contributor

dionysuzx commented Dec 15, 2024

Fixes #1386.

@dionysuzx: Can you confirm it improves your situation please?

Hi @GuillaumeGomez, thank you! I have just been testing it over the last half hour, and I noticed something odd. For some reason on my iPhone 15, it is displaying A18 Bionic. So for some reason, it is interpreting my phone as an iPhone 16, instead of iPhone 15.

Do you know why that might be? I did notice iPhone 15 is not included in the match statement.

If not, I need to check with the tauri community, iOS builds are new, and I feel like it might be possible the target build is somehow for an iPhone 16 (latest), but it runs on my iPhone 15..?

Let me know if you have any other insights, otherwise looks like I have some digging to do. I did do a debug statement to confirm:

image

@dionysuzx
Copy link
Contributor

Fixes #1386.

@dionysuzx: Can you confirm it improves your situation please?

Hi @GuillaumeGomez, thank you! I have just been testing it over the last half hour, and I noticed something odd. For some reason on my iPhone 15, it is displaying A18 Bionic. So for some reason, it is interpreting my phone as an iPhone 16, instead of iPhone 15.

Do you know why that might be? I did notice iPhone 15 is not included in the match statement.

If not, I need to check with the tauri community, iOS builds are new, and I feel like it might be possible the target build is somehow for an iPhone 16 (latest), but it runs on my iPhone 15..?

Let me know if you have any other insights, otherwise looks like I have some digging to do. I did do a debug statement to confirm:

image

Update! I actually think this is valid! Give me another day or so and I'll make sure it works correctly for my device, and hopefully others. I might need to check the second part of the identifier after the comma and put that into the match.

@GuillaumeGomez
Copy link
Owner Author

I think the second part will definitely be needed because depending on the iPhone model (in the same number), the CPU might be different. But again I don't have iPhones so I'll need others to fill the list. :)

@dionysuzx
Copy link
Contributor

I think the second part will definitely be needed because depending on the iPhone model (in the same number), the CPU might be different. But again I don't have iPhones so I'll need others to fill the list. :)

yes. i opened a PR here: #1429

Fix CPU names for iPhone and iPad
@GuillaumeGomez GuillaumeGomez merged commit 98ccbfa into master Dec 18, 2024
12 of 15 checks passed
@GuillaumeGomez GuillaumeGomez deleted the missing-cpu-brands branch December 18, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brand() returns empty on iOS device
2 participants