fix(win): fix HSTRING being dropped, causing NERR_UserNotFound errors #1414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to fix #1233, a pull request #1359 was made which introduced broken code into the repo, shown below:
This caused inconsistent behavior when returning groups for users, as the data in the HSTRING was freed before it could be used in the
get_groups_for_user
function. Additionally, HSTRING internals already terminate given strings with a null byte, making the code above irrelevant.This PR ensures that the Vec data is appropriately null terminated and the heap memory it points to will last for the duration of the
get_groups_for_user
function, as expected.