Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve components retrieval on Windows #1391

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Improve components retrieval on Windows #1391

merged 1 commit into from
Nov 26, 2024

Conversation

GuillaumeGomez
Copy link
Owner

Fixes #365.

@GuillaumeGomez GuillaumeGomez force-pushed the windows-components branch 3 times, most recently from 80b0f81 to becbc9a Compare November 25, 2024 20:51
@GuillaumeGomez
Copy link
Owner Author

@vitoway: Can you give a try to this PR to see if it solves your issue?

@vitoway
Copy link

vitoway commented Nov 26, 2024

@vitoway: Can you give a try to this PR to see if it solves your issue?

Ok, I've tested it and it solves the issue.
By the way, this issue can be reproduced with simple.rs by following the steps below:
image

@GuillaumeGomez
Copy link
Owner Author

Didn't have a windows around lately so couldn't check. Thanks for confirming! Merging then.

@GuillaumeGomez GuillaumeGomez merged commit 862493c into master Nov 26, 2024
67 checks passed
@GuillaumeGomez GuillaumeGomez deleted the windows-components branch November 26, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_components() returning a empty array on Windows
2 participants
@GuillaumeGomez @vitoway