Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace REMAINING_FILES static mut with Atomic #1148

Merged
merged 4 commits into from
Nov 18, 2023
Merged

Replace REMAINING_FILES static mut with Atomic #1148

merged 4 commits into from
Nov 18, 2023

Conversation

GnomedDev
Copy link
Contributor

This removes some unsafe code and a clippy allow, I used the strongest Ordering (SeqCst) when the operation ordering mattered and used Relaxed when it doesn't, although could swap it to SeqCst if you want.

GuillaumeGomez
GuillaumeGomez reviewed Nov 17, 2023
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
GuillaumeGomez
GuillaumeGomez reviewed Nov 17, 2023
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@GuillaumeGomez
Copy link
Owner

Thanks for the improvement!

@GuillaumeGomez GuillaumeGomez merged commit 38fdd32 into GuillaumeGomez:master Nov 18, 2023
67 checks passed
@GnomedDev GnomedDev deleted the remove-static-mut branch May 30, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @GuillaumeGomez