fix: refresh process memory on Windows on first update #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! Two things to do: fix clippy warnings and add a test to ensure that the memory information is queried for processes on all supported platforms. |
vthib
force-pushed
the
fix-windows-process-memory-refresh
branch
from
d300a3d to
12e3a0a
Compare
|
Sorry about the delay! Week-end happened and then I completely forgot about this. Should be ok now |
The first time a process is refreshed on windows, its memory values are not fetched. This is only done on a second refresh. Fix this my moving the refresh memory into the process update function.
vthib
force-pushed
the
fix-windows-process-memory-refresh
branch
from
12e3a0a to
bc86118
Compare
GuillaumeGomez
approved these changes
Oct 14, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first time a process is refreshed on windows, its memory values are not fetched. This is only done on a second refresh.
Fix this my moving the refresh memory into the process update function so that it is called
everytime the process is updated.
Fixes #1084