Fix bug in the MultifolderWithCache.seed method #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: EBoguslawski <[email protected]>
EBoguslawski
force-pushed
the
dev_1.11.0_seed_chronics
branch
from
bfeb6a9
to
abddf01
Compare
Signed-off-by: EBoguslawski <[email protected]>
Signed-off-by: EBoguslawski <[email protected]>
|
BDonnot
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use
MultifolderWithCacheto handle chronics and if you filter chronics to keep chronics with high indexes (indexes higher than the number of selected chronics), then you obtain an "index out of bounds" bug.This PR adresses this bug by modifying the shape on the concerned array and adding a test.