Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: separate cluster connect cmd from its implementation logic #159

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Oct 8, 2023

separate gtctl cmd from its implementation logic, this PR only separate cluster connect cmd.

others will be done in the following PRs.

related to: #160

@shawnh2 shawnh2 requested a review from zyy17 October 8, 2023 08:51
@shawnh2 shawnh2 changed the title refactor UIX: separate cluster connect cmd from its implementation logic refactor: separate cluster connect cmd from its implementation logic Oct 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (1452867) 34.75% compared to head (9f74e21) 35.36%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #159      +/-   ##
===========================================
+ Coverage    34.75%   35.36%   +0.61%     
===========================================
  Files           10       11       +1     
  Lines         1315     1377      +62     
===========================================
+ Hits           457      487      +30     
- Misses         766      793      +27     
- Partials        92       97       +5     
Files Coverage Δ
pkg/cmd/gtctl/cluster/create/create.go 0.00% <0.00%> (ø)
pkg/artifacts/manager.go 56.04% <20.00%> (-0.72%) ⬇️
pkg/metadata/manager.go 85.29% <85.29%> (ø)
pkg/helm/helm.go 58.47% <50.00%> (-4.03%) ⬇️
pkg/deployer/baremetal/deployer.go 30.42% <19.23%> (-0.99%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zyy17
Copy link
Collaborator

zyy17 commented Oct 8, 2023

IMHO, I feel that the two approaches are more about style differences, but this approach seems to separate the specific usage points of the method into cmd/gtctl, so it can look cleaner. Let's try your way.

@zyy17
Copy link
Collaborator

zyy17 commented Oct 8, 2023

The PR title seems OK, but why the CI always failed?

@shawnh2
Copy link
Contributor Author

shawnh2 commented Oct 9, 2023

The PR title seems OK, but why the CI always failed?

there is something wrong with current ci, will be fixed in #163

Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyy17 zyy17 merged commit 61684d9 into GreptimeTeam:develop Oct 9, 2023
6 checks passed
@shawnh2 shawnh2 deleted the refactor/change-uix-connect branch October 9, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants