-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: separate cluster connect cmd from its implementation logic #159
refactor: separate cluster connect cmd from its implementation logic #159
Conversation
…t cmd Signed-off-by: sh2 <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #159 +/- ##
===========================================
+ Coverage 34.75% 35.36% +0.61%
===========================================
Files 10 11 +1
Lines 1315 1377 +62
===========================================
+ Hits 457 487 +30
- Misses 766 793 +27
- Partials 92 97 +5
☔ View full report in Codecov by Sentry. |
IMHO, I feel that the two approaches are more about style differences, but this approach seems to separate the specific usage points of the method into |
The PR title seems OK, but why the CI always failed? |
there is something wrong with current ci, will be fixed in #163 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
separate gtctl cmd from its implementation logic, this PR only separate
cluster connect
cmd.others will be done in the following PRs.
related to: #160