feat: init PgElection with candidate registration #5209

CookiePieWw · 2024-12-20T05:31:15Z

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As title. Part of #5208

Previous pr #5201

A candidate first write a (candidate_key, node info + expire time) pair into the pg kv backend, and regularly check the expire time.

If the value expired, raise an error and re-registrate
If not, just renew the expire time

For all_candidates, just get all candidate using candidate_key_prefix, and filter the expired value.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.
This PR requires documentation updates.
API changes are backward compatible.
Schema or data changes are backward compatible.

fix: release advisory lock fix: handle duplicate keys chore: update comments fix: unlock if acquired the lock chore: add TODO and avoid unwrap refactor: check both lock and expire time, add more comments chore: fmt fix: deal with multiple edge cases feat: init PgElection with candidate registration chore: fmt chore: remove

coderabbitai · 2024-12-20T05:31:23Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

src/meta-srv/src/election.rs

codecov · 2024-12-20T12:07:52Z

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (a578eea) to head (5d26354).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5209      +/-   ##
==========================================
- Coverage   84.06%   83.84%   -0.22%     
==========================================
  Files        1181     1184       +3     
  Lines      219334   219881     +547     
==========================================
- Hits       184390   184367      -23     
- Misses      34944    35514     +570

CookiePieWw · 2024-12-21T12:19:37Z

src/meta-srv/src/election/postgres.rs

+        let key_prefix = format!("{}%", key_prefix);
+        let prev = self
+            .client
+            .query(PREFIX_SCAN, &[&key_prefix])


Maybe we can wrap the query up with a function for type safety. It's quite dangerous here to directly use strings.

github-actions bot added the docs-not-required This change does not impact docs. label Dec 20, 2024

This was referenced Dec 20, 2024

feat: init PgElection #5201

Closed

Implement leader election over postgresql #5208

Open

test: add unit test for pg candidate registration

4b05bdb

fengjiachun reviewed Dec 20, 2024

View reviewed changes

src/meta-srv/src/election.rs Show resolved Hide resolved

CookiePieWw added 5 commits December 20, 2024 18:09

test: add unit test for pg candidate registration

0bdedab

chore: update pg env

8ad864f

chore: make ci happy

4ef9166

fix: spawn a background connection thread

30bab10

chore: typo

d4df24d

CookiePieWw force-pushed the candidate-reg branch from 2d1329d to d4df24d Compare December 20, 2024 11:18

CookiePieWw marked this pull request as ready for review December 20, 2024 11:22

CookiePieWw requested a review from MichaelScofield as a code owner December 20, 2024 11:22

CookiePieWw removed the request for review from MichaelScofield December 20, 2024 11:22

CookiePieWw added 2 commits December 20, 2024 19:36

fix: shadow the election client for now

12260fe

fix: fix ci

ab94583

chore: readability

5d26354

CookiePieWw commented Dec 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: init PgElection with candidate registration #5209

feat: init PgElection with candidate registration #5209

CookiePieWw commented Dec 20, 2024 •

edited

Loading

coderabbitai bot commented Dec 20, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Dec 20, 2024 •

edited

Loading

CookiePieWw Dec 21, 2024

feat: init PgElection with candidate registration #5209

Are you sure you want to change the base?

feat: init PgElection with candidate registration #5209

Conversation

CookiePieWw commented Dec 20, 2024 • edited Loading

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

PR Checklist

coderabbitai bot commented Dec 20, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Dec 20, 2024 • edited Loading

Codecov Report

CookiePieWw Dec 21, 2024

Choose a reason for hiding this comment

CookiePieWw commented Dec 20, 2024 •

edited

Loading

codecov bot commented Dec 20, 2024 •

edited

Loading