Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flow): batch builder with type #5195

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Dec 18, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

fix a bug in which null type vector builder is used incorrectly

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • previously, some vector builder is used wrong and could be null vector builder when encounter null value, this is fixed now as passing actual type is supported to build vector&batch in flow

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@discord9 discord9 requested review from zhongzc, waynexia and a team as code owners December 18, 2024 11:41
Copy link
Contributor

coderabbitai bot commented Dec 18, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Dec 18, 2024
@discord9
Copy link
Contributor Author

Fixing failing tests now

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 63 lines in your changes missing coverage. Please review.

Project coverage is 83.81%. Comparing base (7ea8a44) to head (201b683).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5195      +/-   ##
==========================================
- Coverage   84.07%   83.81%   -0.26%     
==========================================
  Files        1181     1181              
  Lines      219203   219329     +126     
==========================================
- Hits       184291   183832     -459     
- Misses      34912    35497     +585     

@discord9 discord9 mentioned this pull request Dec 19, 2024
9 tasks
src/flow/src/expr.rs Outdated Show resolved Hide resolved
src/flow/src/expr.rs Show resolved Hide resolved
src/flow/src/adapter.rs Outdated Show resolved Hide resolved
src/flow/src/compute/render/reduce.rs Outdated Show resolved Hide resolved
@discord9 discord9 force-pushed the flow_fix_type_deduce branch from 43840a2 to ab83399 Compare December 19, 2024 07:32
@waynexia waynexia requested a review from Copilot December 19, 2024 08:15

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • tests/cases/standalone/common/flow/flow_basic.result: Language not supported
  • tests/cases/standalone/common/flow/flow_basic.sql: Language not supported
  • src/flow/src/compute/render/map.rs: Evaluated as low risk
  • src/flow/src/adapter/node_context.rs: Evaluated as low risk
  • src/flow/src/compute/render.rs: Evaluated as low risk
  • src/flow/src/compute/render/reduce.rs: Evaluated as low risk
Comments suppressed due to low confidence (2)

src/flow/src/adapter/util.rs:26

  • Ensure that the new function 'from_proto_to_data_type' has adequate test coverage.
pub fn from_proto_to_data_type(

src/flow/src/adapter/flownode_impl.rs:34

  • [nitpick] The error message provided to with_context is not very descriptive. Consider providing more context about the error.
        .with_context(|_| ExternalSnafu)
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun
Copy link
Collaborator

@discord9 Some conflits

@discord9 discord9 force-pushed the flow_fix_type_deduce branch from ab83399 to 201b683 Compare December 19, 2024 09:01
@discord9 discord9 enabled auto-merge December 19, 2024 09:11
@discord9 discord9 added this pull request to the merge queue Dec 19, 2024
Merged via the queue into GreptimeTeam:main with commit a4d61bc Dec 19, 2024
36 checks passed
@discord9 discord9 deleted the flow_fix_type_deduce branch December 19, 2024 09:33
evenyag pushed a commit that referenced this pull request Dec 20, 2024
* fix: typed builder

* chore: clippy

* chore: rename

* fix: unit tests

* refactor: per review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants