-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(flow): batch builder with type #5195
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Fixing failing tests now |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5195 +/- ##
==========================================
- Coverage 84.07% 83.81% -0.26%
==========================================
Files 1181 1181
Lines 219203 219329 +126
==========================================
- Hits 184291 183832 -459
- Misses 34912 35497 +585 |
43840a2
to
ab83399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (6)
- tests/cases/standalone/common/flow/flow_basic.result: Language not supported
- tests/cases/standalone/common/flow/flow_basic.sql: Language not supported
- src/flow/src/compute/render/map.rs: Evaluated as low risk
- src/flow/src/adapter/node_context.rs: Evaluated as low risk
- src/flow/src/compute/render.rs: Evaluated as low risk
- src/flow/src/compute/render/reduce.rs: Evaluated as low risk
Comments suppressed due to low confidence (2)
src/flow/src/adapter/util.rs:26
- Ensure that the new function 'from_proto_to_data_type' has adequate test coverage.
pub fn from_proto_to_data_type(
src/flow/src/adapter/flownode_impl.rs:34
- [nitpick] The error message provided to
with_context
is not very descriptive. Consider providing more context about the error.
.with_context(|_| ExternalSnafu)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@discord9 Some conflits |
ab83399
to
201b683
Compare
* fix: typed builder * chore: clippy * chore: rename * fix: unit tests * refactor: per review
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
fix a bug in which null type vector builder is used incorrectly
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist