Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump opendal and switch prometheus layer to the upstream impl #5179

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Dec 16, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Fixes #4706

What's changed and what's your intention?

  • Bump opendal from 0.49 to 0.50
  • Switch PrometheusMetricsLayer to the upstream one

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@waynexia waynexia requested review from evenyag, v0y4g3r and a team as code owners December 16, 2024 12:12
Copy link
Contributor

coderabbitai bot commented Dec 16, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Dec 16, 2024
@waynexia
Copy link
Member Author

Draft since the list behavior is changed.

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun marked this pull request as draft December 17, 2024 02:09
@sunng87
Copy link
Member

sunng87 commented Dec 17, 2024

Fixes #4706

@sunng87 sunng87 linked an issue Dec 17, 2024 that may be closed by this pull request
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
@waynexia waynexia marked this pull request as ready for review December 18, 2024 07:47
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.95%. Comparing base (5469832) to head (49c69fb).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5179      +/-   ##
==========================================
- Coverage   84.03%   83.95%   -0.08%     
==========================================
  Files        1173     1177       +4     
  Lines      218777   218662     -115     
==========================================
- Hits       183850   183585     -265     
- Misses      34927    35077     +150     

@waynexia waynexia enabled auto-merge December 18, 2024 08:29
@evenyag evenyag requested a review from killme2008 December 18, 2024 08:52
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The range key of the object store cache changes again......

@waynexia waynexia added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@waynexia waynexia added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@waynexia waynexia enabled auto-merge December 19, 2024 03:23
@waynexia waynexia added this pull request to the merge queue Dec 19, 2024
Merged via the queue into GreptimeTeam:main with commit 422d18d Dec 19, 2024
36 checks passed
@waynexia waynexia deleted the opendal-prometheus branch December 19, 2024 04:01
@evenyag evenyag mentioned this pull request Dec 20, 2024
5 tasks
evenyag added a commit to evenyag/greptimedb that referenced this pull request Dec 20, 2024
Revert "feat: bump opendal and switch prometheus layer to the upstream impl (GreptimeTeam#5179)"

This reverts commit 422d18d.
evenyag pushed a commit that referenced this pull request Dec 20, 2024
…5179)

* feat: bump opendal and switch prometheus layer to the upstream impl

Signed-off-by: Ruihang Xia <[email protected]>

* remove unused files

Signed-off-by: Ruihang Xia <[email protected]>

* fix tests

Signed-off-by: Ruihang Xia <[email protected]>

* remove unused things

Signed-off-by: Ruihang Xia <[email protected]>

* remove root dir on recovering cache

Signed-off-by: Ruihang Xia <[email protected]>

* filter out non-files entry in test

Signed-off-by: Ruihang Xia <[email protected]>

---------

Signed-off-by: Ruihang Xia <[email protected]>
evenyag added a commit that referenced this pull request Dec 20, 2024
Revert "feat: bump opendal and switch prometheus layer to the upstream impl (#5179)"

This reverts commit 422d18d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use opendal upstream Prometheus layer
4 participants