-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump opendal and switch prometheus layer to the upstream impl #5179
Conversation
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Draft since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #4706 |
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5179 +/- ##
==========================================
- Coverage 84.03% 83.95% -0.08%
==========================================
Files 1173 1177 +4
Lines 218777 218662 -115
==========================================
- Hits 183850 183585 -265
- Misses 34927 35077 +150 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The range key of the object store cache changes again......
Signed-off-by: Ruihang Xia <[email protected]>
Revert "feat: bump opendal and switch prometheus layer to the upstream impl (GreptimeTeam#5179)" This reverts commit 422d18d.
…5179) * feat: bump opendal and switch prometheus layer to the upstream impl Signed-off-by: Ruihang Xia <[email protected]> * remove unused files Signed-off-by: Ruihang Xia <[email protected]> * fix tests Signed-off-by: Ruihang Xia <[email protected]> * remove unused things Signed-off-by: Ruihang Xia <[email protected]> * remove root dir on recovering cache Signed-off-by: Ruihang Xia <[email protected]> * filter out non-files entry in test Signed-off-by: Ruihang Xia <[email protected]> --------- Signed-off-by: Ruihang Xia <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
Fixes #4706
What's changed and what's your intention?
0.49
to0.50
PrometheusMetricsLayer
to the upstream oneChecklist