-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adjust WAL purge default configurations #5107
feat: adjust WAL purge default configurations #5107
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5107 +/- ##
==========================================
- Coverage 84.02% 83.82% -0.21%
==========================================
Files 1162 1167 +5
Lines 216740 217331 +591
==========================================
+ Hits 182122 182172 +50
- Misses 34618 35159 +541 |
e68c13e
to
24c66d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to run TSBS to see if the default options can cause regression
Can we quickly benchmark writing based on this branch? |
The performance impact is small under TSBS. Before
After
This reduces the WAL size during running TSBS (4.8 G -> 1.3 ~ 1.5 G). |
* feat: adjust WAL purge default configurations * fix: config * feat: change raft engine file_size default to 128Mib
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
Close #5106
What's changed and what's your intention?
Adjust the default value of WAL purge configuration.
Checklist