Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust WAL purge default configurations #5107

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

killme2008
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Close #5106

What's changed and what's your intention?

Adjust the default value of WAL purge configuration.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@killme2008 killme2008 requested a review from a team as a code owner December 6, 2024 02:18
Copy link
Contributor

coderabbitai bot commented Dec 6, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Dec 6, 2024
@killme2008 killme2008 requested review from evenyag and v0y4g3r December 6, 2024 02:18
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.82%. Comparing base (2b699e7) to head (a87ea06).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5107      +/-   ##
==========================================
- Coverage   84.02%   83.82%   -0.21%     
==========================================
  Files        1162     1167       +5     
  Lines      216740   217331     +591     
==========================================
+ Hits       182122   182172      +50     
- Misses      34618    35159     +541     

config/config.md Outdated Show resolved Hide resolved
@killme2008 killme2008 force-pushed the feature/adjust-wal-default-size branch from e68c13e to 24c66d0 Compare December 6, 2024 07:04
@killme2008 killme2008 requested a review from evenyag December 6, 2024 07:05
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to run TSBS to see if the default options can cause regression

src/common/wal/src/config/raft_engine.rs Outdated Show resolved Hide resolved
@killme2008
Copy link
Contributor Author

We may need to run TSBS to see if the default options can cause regression

Can we quickly benchmark writing based on this branch?

@evenyag
Copy link
Contributor

evenyag commented Dec 11, 2024

We may need to run TSBS to see if the default options can cause regression

Can we quickly benchmark writing based on this branch?

The performance impact is small under TSBS.

Before

Summary:
loaded 1036800000 metrics in 278.533sec with 6 workers (mean rate 3722357.59 metrics/sec)
loaded 103680000 rows in 278.533sec with 6 workers (mean rate 372235.76 rows/sec)

Summary:
loaded 1036800000 metrics in 276.704sec with 6 workers (mean rate 3746967.42 metrics/sec)
loaded 103680000 rows in 276.704sec with 6 workers (mean rate 374696.74 rows/sec)

After

Summary:
loaded 1036800000 metrics in 281.590sec with 6 workers (mean rate 3681954.22 metrics/sec)
loaded 103680000 rows in 281.590sec with 6 workers (mean rate 368195.42 rows/sec)


Summary:
loaded 1036800000 metrics in 278.871sec with 6 workers (mean rate 3717847.60 metrics/sec)
loaded 103680000 rows in 278.871sec with 6 workers (mean rate 371784.76 rows/sec)


Summary:
loaded 1036800000 metrics in 275.096sec with 6 workers (mean rate 3768864.60 metrics/sec)
loaded 103680000 rows in 275.096sec with 6 workers (mean rate 376886.46 rows/sec)

This reduces the WAL size during running TSBS (4.8 G -> 1.3 ~ 1.5 G).

@evenyag evenyag added this pull request to the merge queue Dec 11, 2024
Merged via the queue into GreptimeTeam:main with commit 2c4ac76 Dec 11, 2024
44 checks passed
evenyag pushed a commit that referenced this pull request Dec 20, 2024
* feat: adjust WAL purge default configurations

* fix: config

* feat: change raft engine file_size default to 128Mib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adjusting the default purge size and interval of the WAL
3 participants