feat(mito): parquet memtable reader #4967
Open
+1,061
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4967 +/- ##
==========================================
- Coverage 84.03% 83.82% -0.22%
==========================================
Files 1146 1160 +14
Lines 213828 216913 +3085
==========================================
+ Hits 179690 181822 +2132
- Misses 34138 35091 +953 |
evenyag
reviewed
Nov 14, 2024
v0y4g3r
force-pushed
the
refactor/separate-paraquet-reader
branch
from
0d0d634 to
356bb47
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 10 changed files in this pull request and generated no suggestions.
Files not reviewed (5)
- src/mito2/src/memtable/bulk.rs: Evaluated as low risk
- src/mito2/src/read/last_row.rs: Evaluated as low risk
- src/mito2/src/error.rs: Evaluated as low risk
- src/mito2/src/sst/parquet.rs: Evaluated as low risk
- src/mito2/src/sst/parquet/row_group.rs: Evaluated as low risk
Comments skipped due to low confidence (1)
src/mito2/src/memtable/bulk/context.rs:0
- The new behavior introduced in
BulkIterContextis not covered by tests. Add unit tests to ensure its correctness.
pub(crate) struct BulkIterContext {
waynexia
approved these changes
Dec 16, 2024
|
Some conflits, PTAL @v0y4g3r |
- Added early return when fetch_ranges is empty to optimize performance. - Replaced inline chunk data assignment with a call to `assign_dense_chunk` for cleaner code.
- Introduced `RangeBase` to `BulkIterContext` for improved filter handling. - Implemented filter application in `BulkPartIter` to prune batches based on predicates. - Updated `SimpleFilterContext::new_opt` to be public for broader access.
- Modified `BulkPart::read` to return `Option<BoxedBatchIterator>` to handle cases where no row groups are selected. - Added logic to return `None` when all row groups are filtered out. - Updated tests to handle the new return type and added a test case to verify behavior when no row groups match the pr
…et metadata and integrate it into BulkPartEncoder
Change BulkPartEncoder row_group_size from Option to usize and update tests
…le iteration and refactor part reading • Introduce context module to encapsulate context for bulk memtable iteration. • Refactor BulkPart to use BulkIterContextRef for reading operations. • Remove redundant code in BulkPart by centralizing context creation and row group pruning logic in the new context module. • Create new file context.rs with structures and logic for handling iteration context. • Adjust part_reader.rs and row_group_reader.rs to reference the new BulkIterContextRef.
… implementations in memtable and parquet reader modules • Rename RowGroupReaderVirtual to RowGroupReaderContext for clarity. • Replace BulkPartVirt with direct usage of BulkIterContextRef in MemtableRowGroupReader. • Simplify MemtableRowGroupReaderBuilder by directly passing context instead of creating a BulkPartVirt instance. • Update RowGroupReaderBase to use context field instead of virt, reflecting the trait renaming and usage. • Modify FileRangeVirt to FileRangeContextRef and adjust implementations accordingly.
…on and remove unused code • Centralize creation of SerializedPageReader in RowGroupBase::column_reader method. • Remove unused RowGroupCachedReader and related code from MemtableRowGroupPageFetcher. • Eliminate redundant error handling for invalid column index in multiple places.
v0y4g3r
force-pushed
the
refactor/separate-paraquet-reader
branch
from
1ec83c2 to
65d3158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR adds basic support for reading parquet files residing in memory, by reusing some structs and functions in sst mod.
Since the lack of keyword generics, we have to refactor the parquet reader by extracting the methods and functions that are not related to async/sync IO operations to a
[___]Basestructs that can be shared between memory and files.Checklist