revert: set default compresion to LZ4 #4312
Conversation
This reverts commit bc398cf.
WalkthroughThe overall change involves updating Kafka compression settings in the WAL (Write-Ahead Logging) options. Specifically, the compression type has been changed from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- src/common/meta/src/wal_options_allocator/kafka/topic_manager.rs (1 hunks)
- src/common/wal/src/config.rs (2 hunks)
- src/common/wal/src/config/kafka/datanode.rs (1 hunks)
- src/common/wal/src/config/kafka/standalone.rs (1 hunks)
Additional comments not posted (5)
src/common/wal/src/config/kafka/datanode.rs (1)
49-49: LGTM!The compression setting in the
DatanodeKafkaConfigstruct's default implementation has been correctly reverted toCompression::NoCompression.src/common/wal/src/config/kafka/standalone.rs (1)
70-70: LGTM!The compression setting in the
StandaloneKafkaConfigstruct's default implementation has been correctly reverted toCompression::NoCompression.src/common/wal/src/config.rs (2)
210-210: LGTM!The compression setting in the
DatanodeKafkaConfigstruct has been correctly reverted to useCompression::default().
232-232: LGTM!The compression setting in the
StandaloneKafkaConfigstruct has been correctly reverted to useCompression::default().src/common/meta/src/wal_options_allocator/kafka/topic_manager.rs (1)
176-176: LGTM!The compression setting in the
try_append_noop_recordfunction has been correctly reverted toCompression::NoCompression.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4312 +/- ##
==========================================
- Coverage 85.15% 85.14% -0.01%
==========================================
Files 1060 1060
Lines 187543 187543
==========================================
- Hits 159693 159689 -4
- Misses 27850 27854 +4 |
|
Somehow we may investigate how to do the compression and avoid stack overflow ... Any ideas why it causes stack overflow? |
|
I think we should find the root cause. |
Yes, I will investigate it ASAP. However, If we can't find the root cause before releasing the new version, we'd better to revert the PR? |
|
Already done in #4303 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Due to #4304
Reverts #4294
Checklist
Summary by CodeRabbit
Lz4toNoCompressionfor topic management and various configurations.These changes aim to standardize compression settings across the application, potentially improving consistency and performance.