Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump OpenDAL to 0.47.2 #4297

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jul 5, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

OpenDAL 0.47.2 fixes a critical bug, Gcs's RangeWrite doesn't support concurrent write 🥲

See also:
fix(core): Gcs's RangeWrite doesn't support concurrent write in apache/opendal#4806
feat(core/gcs): Add concurrent write for gcs back in apache/opendal#4820

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested a review from a team as a code owner July 5, 2024 07:34
Copy link
Contributor

coderabbitai bot commented Jul 5, 2024

Important

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@WenyXu WenyXu force-pushed the chore/bump-opendal branch from 3f237c4 to fcc0f85 Compare July 5, 2024 07:42
@WenyXu WenyXu requested a review from tisonkun July 5, 2024 07:42
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jul 5, 2024
@WenyXu WenyXu force-pushed the chore/bump-opendal branch from fcc0f85 to 04115d8 Compare July 5, 2024 07:45
@WenyXu WenyXu enabled auto-merge July 5, 2024 07:54
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.01%. Comparing base (849e0b9) to head (04115d8).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4297      +/-   ##
==========================================
- Coverage   85.31%   85.01%   -0.31%     
==========================================
  Files        1063     1066       +3     
  Lines      188345   188636     +291     
==========================================
- Hits       160686   160367     -319     
- Misses      27659    28269     +610     

@WenyXu WenyXu requested a review from fengjiachun July 5, 2024 10:48
@WenyXu WenyXu added this pull request to the merge queue Jul 5, 2024
Merged via the queue into GreptimeTeam:main with commit 30b65ca Jul 5, 2024
52 checks passed
@WenyXu WenyXu deleted the chore/bump-opendal branch July 5, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants