ci: push latest greptimedb nigthly build image #4260
Conversation
WalkthroughThis update enhances the release process for container images. Specifically, the workflow now pushes a versioned image instead of using the latest tag. The nightly-build configurations have been adjusted to enable the pushing of the latest tag to the registry, improving the traceability and consistency of image deployment. Changes
Sequence DiagramssequenceDiagram
actor User
participant GitHubActions as GitHub Actions
participant DockerHub
participant ACR
User->>GitHubActions: Trigger workflow
GitHubActions->>DockerHub: Pull greptimedb-centos:latest
GitHubActions->>DockerHub: Pull greptimedb-centos:${{ inputs.version }}
GitHubActions->>ACR: Push greptimedb-centos:${{ inputs.version }}
GitHubActions->>ACR: Push greptimedb-centos:latest
ACR-->>User: Confirmation of push
Poem
Tip AI model upgrade
|
zyy17
requested review from
evenyag,
waynexia,
WenyXu and
daviderli614
and removed request for
a team
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/actions/release-cn-artifacts/action.yaml (1 hunks)
- .github/workflows/nightly-build.yml (2 hunks)
Additional comments not posted (4)
.github/actions/release-cn-artifacts/action.yaml (2)
126-128: LGTM!The script now pushes a specific version of the image instead of the latest tag. This change ensures that the correct version of the image is pushed, which is crucial for reproducibility and consistency.
129-131: LGTM!The script now explicitly states that it is pushing the latest
greptimedb-centosimage from DockerHub to ACR. This change ensures that the latest image is always pushed, which is important for keeping the registry up-to-date..github/workflows/nightly-build.yml (2)
202-202: LGTM!The
push-latest-tagsetting has been changed fromfalsetotrue. This change enables the job to push the latest tag to the registry, ensuring that the latest build is always available.
243-243: LGTM!The
push-latest-tagsetting has been changed fromfalsetotrue. This change ensures that the latest tag is pushed to the registry for the CN region, keeping it up-to-date with the latest build.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4260 +/- ##
==========================================
- Coverage 84.97% 84.95% -0.02%
==========================================
Files 1054 1054
Lines 187154 187160 +6
==========================================
- Hits 159037 159011 -26
- Misses 28117 28149 +32 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Since we use a new namespace for the nightly build image(not the scheduled released version), we can push the latest tag for those images.
Also, it resolves the issue of failing to push nightly images to ACR.
Checklist