-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Display
for PartitionExpr
#4087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I have a suggestion to write the test in a more tidy way:
let cases = [
(Operand::Column(..), RestrictedOp::.., Operand::Column(..), "a = b"),
...
]
or even pack the input and output into a temporary struct,
This patch itself is good to merge.
Thanks for your contribution!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4087 +/- ##
==========================================
- Coverage 85.49% 85.19% -0.30%
==========================================
Files 991 991
Lines 172968 173053 +85
==========================================
- Hits 147878 147437 -441
- Misses 25090 25616 +526 |
Thanks, updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
This closes #3985 .
What's changed and what's your intention?
!!! DO NOT LEAVE THIS BLOCK EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist