-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid acquiring lock during reading stats #4070
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
requested review from
waynexia,
v0y4g3r,
evenyag and
a team
as code owners
May 29, 2024 16:18
Good catch! |
killme2008
reviewed
May 29, 2024
waynexia
approved these changes
May 30, 2024
evenyag
approved these changes
May 30, 2024
fengjiachun
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4070 +/- ##
==========================================
- Coverage 85.34% 85.04% -0.31%
==========================================
Files 987 987
Lines 171485 172109 +624
==========================================
+ Hits 146359 146371 +12
- Misses 25126 25738 +612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR uses
Arc<Atomicu64>
to store the shared value instead ofRwLock
, to avoid acquiring lock during reading value.The datanode will report the stats (like manifest usage) via heartbeat. Before sending the heartbeat to the metasrv, it collects all stats from the region server. While collecting
disk_usage
will invoke themanifest_usage
method on themanifest_manager
, this operation is required to acquire the read lock of themanifest_manager
.However, acquiring a read lock will be blocked by the updating manifest operations, and the wait time may be as long as tens of seconds. This makes the datanode fail to send heartbeats in time, then all region leases on the datanodes will expire.
Checklist