Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move Database to client crate behind testing feature #4059

Merged
merged 6 commits into from
May 28, 2024

Conversation

tisonkun
Copy link
Collaborator

@tisonkun tisonkun commented May 28, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This reverts #3820 and instead move Databas to client crate behind testing feature.

This supersedes #4059.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@tisonkun tisonkun requested a review from a team as a code owner May 28, 2024 01:33
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 28, 2024
@tisonkun tisonkun requested a review from killme2008 May 28, 2024 01:43
Signed-off-by: tison <[email protected]>
@tisonkun tisonkun force-pushed the revert-dbchanges branch from 3724221 to 383e571 Compare May 28, 2024 01:44
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 61.16505% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 85.01%. Comparing base (097f62f) to head (383e571).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4059      +/-   ##
==========================================
- Coverage   85.41%   85.01%   -0.40%     
==========================================
  Files         985      987       +2     
  Lines      170616   171031     +415     
==========================================
- Hits       145724   145403     -321     
- Misses      24892    25628     +736     

@tisonkun tisonkun enabled auto-merge May 28, 2024 02:24
@tisonkun tisonkun added this pull request to the merge queue May 28, 2024
Merged via the queue into GreptimeTeam:main with commit 9dd6e03 May 28, 2024
28 checks passed
@tisonkun tisonkun deleted the revert-dbchanges branch May 28, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants