Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open region in background #4052

Merged
merged 5 commits into from
May 28, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 27, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4026

What's changed and what's your intention?

Previously, a single Worker could only open regions in serial(the handle_open_request requires &mut self). This PR allows for the opening of regions in the background(in parallel).

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 27, 2024
@WenyXu WenyXu force-pushed the feat/open-region-background branch from 247e00c to 9be018a Compare May 27, 2024 08:38
@WenyXu WenyXu force-pushed the feat/open-region-background branch from 9be018a to f7fb14b Compare May 27, 2024 08:42
@WenyXu WenyXu marked this pull request as ready for review May 27, 2024 08:43
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 96.93878% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 85.05%. Comparing base (c78043d) to head (53a98e2).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4052      +/-   ##
==========================================
- Coverage   85.42%   85.05%   -0.37%     
==========================================
  Files         984      987       +3     
  Lines      170481   171204     +723     
==========================================
- Hits       145631   145622       -9     
- Misses      24850    25582     +732     

@WenyXu WenyXu requested a review from fengjiachun May 27, 2024 09:06
src/mito2/src/worker/handle_open.rs Outdated Show resolved Hide resolved
src/mito2/src/worker/handle_open.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu marked this pull request as draft May 28, 2024 02:26
@WenyXu WenyXu force-pushed the feat/open-region-background branch from 6e1b526 to c337836 Compare May 28, 2024 03:38
@WenyXu WenyXu marked this pull request as ready for review May 28, 2024 03:38
@WenyXu WenyXu force-pushed the feat/open-region-background branch from c337836 to 1a55292 Compare May 28, 2024 04:32
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/mito2/src/worker/handle_open.rs Show resolved Hide resolved
@WenyXu WenyXu requested a review from a team as a code owner May 28, 2024 12:10
src/mito2/src/request.rs Outdated Show resolved Hide resolved
src/mito2/src/request.rs Outdated Show resolved Hide resolved
src/mito2/src/worker/handle_open.rs Outdated Show resolved Hide resolved
src/mito2/src/worker/handle_open.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@WenyXu WenyXu added this pull request to the merge queue May 28, 2024
Merged via the queue into GreptimeTeam:main with commit 4aa756c May 28, 2024
28 checks passed
@WenyXu WenyXu deleted the feat/open-region-background branch May 28, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants