-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opertor): check if a database is in use before dropping it #4035
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4035 +/- ##
==========================================
- Coverage 85.42% 85.12% -0.31%
==========================================
Files 983 983
Lines 170493 170493
==========================================
- Hits 145652 145139 -513
- Misses 24841 25354 +513 |
@killme2008 @waynexia also I'm not sure I understand why "CI / Unstable Fuzz Test (unstable_fuzz_create_table_standalone)" is failing if you could point me out I'll be very grateful 🙏 |
The fuzz test will drop in-use database( |
Thank you Ruihang! I assume the rest is looks ok? |
LGTM, But @waynexia he is Ruihang🤣 |
ohhhh....sorry Weny!!!! I would try tackling the test in the next couple of days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@WenyXu There is a fuzz test failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to @waynexia 😋
Many thanks to @WenyXu for fixing the failing test 🙏 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#4029
What's changed and what's your intention?
check if a database/schema is in use before dropping it.
Checklist