Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the LogStoreRawEntryReader and RawEntryReaderFilter #4030

Merged
merged 3 commits into from
May 24, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 24, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4026

What's changed and what's your intention?

  1. Implement the LogStoreRawEntryReader, which reads undecoded raw WAL entries from the underlying LogStore implementation.
  2. Implement the RawEntryReaderFilter

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 85.13%. Comparing base (466f7c6) to head (76121ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4030      +/-   ##
==========================================
- Coverage   85.43%   85.13%   -0.30%     
==========================================
  Files         980      983       +3     
  Lines      170221   170493     +272     
==========================================
- Hits       145423   145151     -272     
- Misses      24798    25342     +544     

@WenyXu WenyXu force-pushed the feat/raw-entry-reader branch 2 times, most recently from 92bf20a to ad6e2e7 Compare May 24, 2024 08:36
@WenyXu WenyXu force-pushed the feat/raw-entry-reader branch from ad6e2e7 to 76121ab Compare May 24, 2024 08:38
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue May 24, 2024
Merged via the queue into GreptimeTeam:main with commit 5df3d4e May 24, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants