Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move log_version() into build() of App to fix no log version on bootstrap #4004

Merged
merged 1 commit into from
May 21, 2024
Merged

fix: move log_version() into build() of App to fix no log version on bootstrap #4004

merged 1 commit into from
May 21, 2024

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented May 21, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Move log_version() into build() of App to fix no log version on bootstrap since the common_telemetry::init_global_logging is in the build().

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@zyy17 zyy17 requested a review from a team as a code owner May 21, 2024 09:02
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 21, 2024
@evenyag evenyag enabled auto-merge May 21, 2024 09:11
@evenyag evenyag added this pull request to the merge queue May 21, 2024
Merged via the queue into GreptimeTeam:main with commit 4778575 May 21, 2024
29 checks passed
@zyy17 zyy17 deleted the fix/log-version-failed branch May 26, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenyag evenyag evenyag approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zyy17 @MichaelScofield @evenyag