Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make create view procedure simple as others #4001

Merged

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As the title said.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@fengjiachun fengjiachun requested review from waynexia and WenyXu May 21, 2024 07:45
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 90.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 85.17%. Comparing base (179c8c7) to head (4ff6c41).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4001      +/-   ##
==========================================
- Coverage   85.48%   85.17%   -0.32%     
==========================================
  Files         977      977              
  Lines      169348   169341       -7     
==========================================
- Hits       144773   144230     -543     
- Misses      24575    25111     +536     

@fengjiachun fengjiachun enabled auto-merge May 21, 2024 08:26
@fengjiachun fengjiachun added this pull request to the merge queue May 21, 2024
Merged via the queue into GreptimeTeam:main with commit 0aa523c May 21, 2024
30 checks passed
@fengjiachun fengjiachun deleted the feat/simple-procedure-code branch May 21, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants