Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): prevent exporting physical table data #3978

Merged
merged 2 commits into from
May 17, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 17, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

prevent exporting physical table data

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested a review from a team as a code owner May 17, 2024 14:14
@WenyXu WenyXu mentioned this pull request May 17, 2024
13 tasks
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 17, 2024
@WenyXu WenyXu force-pushed the feat/data-export-tool branch from 8b094c9 to ea5bf34 Compare May 17, 2024 14:21
src/cmd/src/cli/export.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 85.12%. Comparing base (3477fde) to head (ea5bf34).
Report is 1 commits behind head on main.

Current head ea5bf34 differs from pull request most recent head 08aebfd

Please upload reports for the commit 08aebfd to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3978      +/-   ##
==========================================
- Coverage   85.41%   85.12%   -0.29%     
==========================================
  Files         978      978              
  Lines      169090   169095       +5     
==========================================
- Hits       144425   143944     -481     
- Misses      24665    25151     +486     

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu enabled auto-merge May 17, 2024 14:40
@WenyXu WenyXu added this pull request to the merge queue May 17, 2024
Merged via the queue into GreptimeTeam:main with commit 11a08cb May 17, 2024
19 checks passed
@WenyXu WenyXu deleted the feat/data-export-tool branch May 17, 2024 15:14
WenyXu added a commit to WenyXu/greptimedb that referenced this pull request May 21, 2024
* feat: prevent exporting physical table data

* chore: apply suggestions from CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants