Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tql parser hang on abnormal input #3977

Merged
merged 2 commits into from
May 17, 2024
Merged

fix: tql parser hang on abnormal input #3977

merged 2 commits into from
May 17, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented May 17, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

I find this occasionally by a typo

image

And flamegraph tells me there is a dead loop
image

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@waynexia waynexia requested a review from a team as a code owner May 17, 2024 13:04
@WenyXu WenyXu mentioned this pull request May 17, 2024
Closed
13 tasks
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 17, 2024
@waynexia waynexia enabled auto-merge May 17, 2024 13:06
@WenyXu WenyXu requested review from fengjiachun, evenyag and WenyXu May 17, 2024 13:06
@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.11%. Comparing base (e2a1cb5) to head (5d4eaf0).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3977      +/-   ##
==========================================
- Coverage   85.42%   85.11%   -0.31%     
==========================================
  Files         978      978              
  Lines      168436   169090     +654     
==========================================
+ Hits       143886   143923      +37     
- Misses      24550    25167     +617

evenyag
evenyag approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/sql/src/parsers/tql_parser.rs Outdated Show resolved Hide resolved
@etolbakov
Copy link
Collaborator

sorry about that 😢 @waynexia

@waynexia
apply review sugg
5d4eaf0 
Signed-off-by: Ruihang Xia <[email protected]>
@waynexia
Copy link
Member Author

sorry about that 😢 @waynexia

It's ok -- I won't consider this either without this typo

@waynexia waynexia added this pull request to the merge queue May 17, 2024
Merged via the queue into GreptimeTeam:main with commit e9b178b May 17, 2024
20 checks passed
@waynexia waynexia deleted the fix-tql branch May 17, 2024 14:38
WenyXu pushed a commit to WenyXu/greptimedb that referenced this pull request May 21, 2024
@waynexia @WenyXu
fix: tql parser hang on abnormal input (GreptimeTeam#3977)
7c56d24 
* fix: tql parser hang on abnormal input

Signed-off-by: Ruihang Xia <[email protected]>

* apply review sugg

Signed-off-by: Ruihang Xia <[email protected]>

---------

Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etolbakov etolbakov etolbakov left review comments

@WenyXu WenyXu WenyXu approved these changes

@evenyag evenyag evenyag approved these changes

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waynexia @etolbakov @evenyag @WenyXu