Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent exporting metric physical table data #3970

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 17, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

prevent exporting metric physical table data

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested a review from a team as a code owner May 17, 2024 06:45
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 17, 2024
@WenyXu WenyXu mentioned this pull request May 17, 2024
13 tasks
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.07%. Comparing base (5c0a530) to head (b39cc40).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3970      +/-   ##
==========================================
- Coverage   85.37%   85.07%   -0.30%     
==========================================
  Files         978      978              
  Lines      168279   168276       -3     
==========================================
- Hits       143666   143167     -499     
- Misses      24613    25109     +496     

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key Tech!

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue May 17, 2024
Merged via the queue into GreptimeTeam:main with commit 0168d43 May 17, 2024
22 checks passed
WenyXu added a commit to WenyXu/greptimedb that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants