Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: give windows file watcher more time #3953

Merged
merged 2 commits into from
May 16, 2024

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented May 15, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Give file change detection test on windows more time.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@sunng87 sunng87 requested a review from a team as a code owner May 15, 2024 17:30
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 15, 2024
Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may prefer to conditionally define the timeout constant ...

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.34%. Comparing base (66aa08d) to head (11fad61).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3953      +/-   ##
==========================================
- Coverage   86.03%   85.34%   -0.69%     
==========================================
  Files         955      972      +17     
  Lines      163870   166846    +2976     
==========================================
+ Hits       140990   142403    +1413     
- Misses      22880    24443    +1563     

@sunng87 sunng87 requested review from zyy17, evenyag and tisonkun May 15, 2024 18:41
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue May 16, 2024
Merged via the queue into GreptimeTeam:main with commit fe34ebf May 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants