Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: implement docbot in cyborg #3937

Merged
merged 6 commits into from
May 15, 2024
Merged

ci: implement docbot in cyborg #3937

merged 6 commits into from
May 15, 2024

Conversation

tisonkun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This closes #3855. Let me test it out in the fork first.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Sorry, something went wrong.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested a review from a team as a code owner May 14, 2024 08:22
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 14, 2024
@tisonkun tisonkun marked this pull request as draft May 14, 2024 08:29
@tisonkun
Copy link
Collaborator Author

tisonkun commented May 14, 2024

A few improvements can be made. Testing at tisonkun#4.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.34%. Comparing base (f16ce3c) to head (0f06875).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3937      +/-   ##
==========================================
- Coverage   85.79%   85.34%   -0.46%     
==========================================
  Files         965      971       +6     
  Lines      165107   166798    +1691     
==========================================
+ Hits       141654   142346     +692     
- Misses      23453    24452     +999     

tisonkun added 4 commits May 14, 2024 16:42
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun marked this pull request as ready for review May 14, 2024 08:56
@tisonkun
Copy link
Collaborator Author

Should be ready for review now.

@tisonkun tisonkun requested review from evenyag and nicecui May 14, 2024 08:57
@tisonkun tisonkun requested review from sunng87 and fengjiachun May 15, 2024 08:00
@tisonkun
Copy link
Collaborator Author

cc @nicecui may you check this workflow makes sense to you.

Copy link
Collaborator

@nicecui nicecui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue May 15, 2024
@tisonkun tisonkun removed this pull request from the merge queue due to a manual request May 15, 2024
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun enabled auto-merge May 15, 2024 12:41
@tisonkun tisonkun added this pull request to the merge queue May 15, 2024
Merged via the queue into GreptimeTeam:main with commit 6c621b7 May 15, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process docs updates
3 participants