-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metric engine): label mismatch in metric engine #3927
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3927 +/- ##
==========================================
- Coverage 85.96% 85.45% -0.51%
==========================================
Files 963 967 +4
Lines 164580 166172 +1592
==========================================
+ Hits 141481 142008 +527
- Misses 23099 24164 +1065 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fascinating!
aa028e5
to
81afee6
Compare
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR fixes the issue where the same primary key gets wrong pk index when dict_builder is frozen. The root cause can be found here.
Performance
This PR has little impaction to the ingestion performance of metric engine.
Checklist