Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort unstable HTTP result in label values query #3920

Merged
merged 3 commits into from
May 11, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

sort the unstable field list to make result stable

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@waynexia waynexia requested a review from a team as a code owner May 11, 2024 11:16
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 11, 2024
@waynexia waynexia enabled auto-merge May 11, 2024 11:17
@waynexia waynexia added this pull request to the merge queue May 11, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.66%. Comparing base (36c41d1) to head (3245c73).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3920      +/-   ##
==========================================
- Coverage   85.96%   85.66%   -0.31%     
==========================================
  Files         962      962              
  Lines      164308   164308              
==========================================
- Hits       141252   140749     -503     
- Misses      23056    23559     +503     

Merged via the queue into GreptimeTeam:main with commit 590aedd May 11, 2024
21 checks passed
@waynexia waynexia deleted the fix-label-values branch May 11, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants