Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrieve all info instead of checking on demand #3846

Merged
merged 3 commits into from
May 6, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 30, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

RegionLeaseKeeper should retrieve all operating regions in one operation instead of checking on demand to avoid inconsistencies caused by on-demand checking.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@WenyXu WenyXu requested a review from MichaelScofield as a code owner April 30, 2024 14:13
@WenyXu WenyXu requested a review from fengjiachun April 30, 2024 14:14
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 30, 2024
@WenyXu WenyXu changed the title fix: fix renew region lease bugs fix: retrieve all info instead of checking on demand Apr 30, 2024
@WenyXu WenyXu requested a review from shuiyisong April 30, 2024 14:24
src/common/meta/src/region_keeper.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu marked this pull request as draft May 6, 2024 03:05
@WenyXu WenyXu marked this pull request as ready for review May 6, 2024 04:32
@WenyXu WenyXu enabled auto-merge May 6, 2024 04:32
@WenyXu WenyXu added this pull request to the merge queue May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (20cbc03) to head (d4c97e3).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3846      +/-   ##
==========================================
- Coverage   85.63%   85.29%   -0.35%     
==========================================
  Files         954      955       +1     
  Lines      163214   163323     +109     
==========================================
- Hits       139771   139304     -467     
- Misses      23443    24019     +576     

Merged via the queue into GreptimeTeam:main with commit 6e12e1b May 6, 2024
31 of 42 checks passed
@WenyXu WenyXu deleted the fix/renew-region-lease branch May 6, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants