-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: passing QueryContext to RegionServer #3829
refactor: passing QueryContext to RegionServer #3829
Conversation
bfb1840
to
a8eff60
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3829 +/- ##
==========================================
- Coverage 85.61% 85.29% -0.33%
==========================================
Files 952 952
Lines 163062 163079 +17
==========================================
- Hits 139605 139097 -508
- Misses 23457 23982 +525 |
a8eff60
to
57142a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM.
e0a2535
to
9043dd8
Compare
Hi @Kelvinyu1117 , there are some conflicts need to be resolved. |
Good job! Please resolve the conflicts, then we can merge the PR. @Kelvinyu1117 |
0c332cb
to
b8f9b4b
Compare
Should be fixed. |
Hi @Kelvinyu1117 , The coverage tests failed( |
b8f9b4b
to
b901f82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
close #3752
What's changed and what's your intention?
Allow passing the query context to the region server.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist