Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove duration type from gRPC #3825

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

fengjiachun
Copy link
Collaborator

@fengjiachun fengjiachun commented Apr 28, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As the title said.

GreptimeTeam/greptime-proto#158

close #3230

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@fengjiachun fengjiachun requested a review from a team as a code owner April 28, 2024 08:02
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 28, 2024
@fengjiachun fengjiachun changed the title refactor: remove duration type from gRPC refactor!: remove duration type from gRPC Apr 28, 2024
@github-actions github-actions bot added the breaking-change This pull request contains breaking changes. label Apr 28, 2024
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.48%. Comparing base (ed8b136) to head (c05685a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3825      +/-   ##
==========================================
- Coverage   85.79%   85.48%   -0.32%     
==========================================
  Files         952      952              
  Lines      162684   162393     -291     
==========================================
- Hits       139574   138818     -756     
- Misses      23110    23575     +465     

@tisonkun
Copy link
Collaborator

This should be related or closes #3230.

@fengjiachun
Copy link
Collaborator Author

Waiting for: GreptimeTeam/greptime-proto#158

@fengjiachun fengjiachun requested review from waynexia and evenyag April 28, 2024 08:38
@fengjiachun
Copy link
Collaborator Author

Waiting for: GreptimeTeam/greptime-proto#158

Done

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Apr 29, 2024
Merged via the queue into GreptimeTeam:main with commit 336db38 Apr 29, 2024
20 checks passed
@fengjiachun fengjiachun deleted the refactor/rm-duration-type branch April 29, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This pull request contains breaking changes. docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot show-table with Duration Type
3 participants