Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuzz): add alter logical table target #3818

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

CookiePieWw
Copy link
Collaborator

@CookiePieWw CookiePieWw commented Apr 27, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3741 and #3174

What's changed and what's your intention?

Alter a logical table on the same physical table. Mostly the same as previous alter table fuzz test, but on metric engine.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@CookiePieWw CookiePieWw requested a review from a team as a code owner April 27, 2024 12:35
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 27, 2024
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (e410192) to head (4a1ebc1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3818      +/-   ##
==========================================
- Coverage   85.60%   85.29%   -0.32%     
==========================================
  Files         955      955              
  Lines      163104   163104              
==========================================
- Hits       139625   139113     -512     
- Misses      23479    23991     +512     

@CookiePieWw CookiePieWw force-pushed the alter-logical-table-fuzz-test branch from 534ed6c to 23c454c Compare April 27, 2024 13:11
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add it to CI config

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu added this pull request to the merge queue Apr 28, 2024
Merged via the queue into GreptimeTeam:main with commit f29aebf Apr 28, 2024
20 checks passed
@CookiePieWw CookiePieWw deleted the alter-logical-table-fuzz-test branch April 28, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants