Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: introduce unstable fuzz create table test #3788

Merged
merged 18 commits into from
May 1, 2024
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,7 @@ GT_KAFKA_ENDPOINTS = localhost:9092

# Setting for fuzz tests
GT_MYSQL_ADDR = localhost:4002

# Setting for usntable fuzz tests
tisonkun marked this conversation as resolved.
Show resolved Hide resolved
GT_FUZZ_BINARY_PATH=/path/to/
GT_FUZZ_INSTANCE_ROOT_DIR=/tmp/unstable_greptime
12 changes: 9 additions & 3 deletions .github/actions/fuzz-test/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,17 @@ description: 'Fuzz test given setup and service'
inputs:
target:
description: "The fuzz target to test"
required: true
max-total-time:
description: "Max total time(secs)"
required: true
unstable:
default: 'false'
description: "enable unstable feature"
WenyXu marked this conversation as resolved.
Show resolved Hide resolved
runs:
using: composite
steps:
- name: Run Fuzz Test
shell: bash
run: cargo fuzz run ${{ inputs.target }} --fuzz-dir tests-fuzz -D -s none -- -max_total_time=120
env:
GT_MYSQL_ADDR: 127.0.0.1:4002
run: cargo fuzz run ${{ inputs.target }} --fuzz-dir tests-fuzz -D -s none ${{ inputs.unstable == 'true' && '--features=unstable' || '' }} -- -max_total_time=${{ inputs.max-total-time }}

54 changes: 54 additions & 0 deletions .github/workflows/develop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,62 @@ jobs:
uses: ./.github/actions/fuzz-test
env:
CUSTOM_LIBFUZZER_PATH: /usr/lib/llvm-14/lib/libFuzzer.a
GT_MYSQL_ADDR: 127.0.0.1:4002
with:
target: ${{ matrix.target }}
max-total-time: 120

unstable-fuzztest:
name: Unstable Fuzz Test
needs: build
runs-on: ubuntu-latest
strategy:
matrix:
target: [ "unstable_fuzz_create_table_standalone" ]
steps:
- uses: actions/checkout@v4
- uses: arduino/setup-protoc@v3
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.RUST_TOOLCHAIN }}
- name: Rust Cache
uses: Swatinem/rust-cache@v2
with:
# Shares across multiple jobs
shared-key: "fuzz-test-targets"
- name: Set Rust Fuzz
shell: bash
run: |
sudo apt update && sudo apt install -y libfuzzer-14-dev
cargo install cargo-fuzz
- name: Download pre-built binaries
uses: actions/download-artifact@v4
with:
name: bins
path: .
- name: Unzip binaries
run: tar -xvf ./bins.tar.gz
- name: Fuzz Test
uses: ./.github/actions/fuzz-test
env:
CUSTOM_LIBFUZZER_PATH: /usr/lib/llvm-14/lib/libFuzzer.a
GT_MYSQL_ADDR: 127.0.0.1:4002
GT_FUZZ_BINARY_PATH: ./bins/greptime
GT_FUZZ_INSTANCE_ROOT_DIR: /tmp/unstable-greptime/
with:
target: ${{ matrix.target }}
max-total-time: 120
unstable: 'true'
- name: Upload unstable fuzz test logs
if: failure()
uses: actions/upload-artifact@v4
with:
name: unstable-fuzz-logs
path: /tmp/unstable-greptime/
retention-days: 3


sqlness:
name: Sqlness Test
Expand Down
3 changes: 3 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 16 additions & 1 deletion tests-fuzz/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ workspace = true
[package.metadata]
cargo-fuzz = true

[features]
default = []
unstable = ["nix"]

[dependencies]
arbitrary = { version = "1.3.0", features = ["derive"] }
async-trait = { workspace = true }
Expand All @@ -24,9 +28,11 @@ derive_builder = { workspace = true }
dotenv = "0.15"
lazy_static = { workspace = true }
libfuzzer-sys = "0.4"
nix = { version = "0.28", features = ["process", "signal"], optional = true }
partition = { workspace = true }
rand = { workspace = true }
rand_chacha = "0.3.1"
reqwest = { workspace = true }
serde = { workspace = true }
serde_json = { workspace = true }
snafu = { workspace = true }
Expand All @@ -38,10 +44,11 @@ sqlx = { version = "0.6", features = [
"postgres",
"chrono",
] }
tinytemplate = "1.2"
tokio = { workspace = true }

[dev-dependencies]
dotenv.workspace = true
tokio = { workspace = true }

[[bin]]
name = "fuzz_create_table"
Expand Down Expand Up @@ -70,3 +77,11 @@ path = "targets/fuzz_create_database.rs"
test = false
bench = false
doc = false

[[bin]]
name = "unstable_fuzz_create_table_standalone"
path = "targets/unstable/fuzz_create_table_standalone.rs"
test = false
bench = false
doc = false
required-features = ["unstable"]
19 changes: 19 additions & 0 deletions tests-fuzz/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,25 @@ cargo install cargo-fuzz
2. Start GreptimeDB
3. Copy the `.env.example`, which is at project root, to `.env` and change the values on need.

### For stable fuzz tests
Set the GreptimeDB MySQL address.
```
GT_MYSQL_ADDR = localhost:4002
```

### For unstable fuzz tests
Set the binary path of the GreptimeDB:
```
GT_FUZZ_BINARY_PATH = /path/to/
```

Change the instance root directory(the default value: `/tmp/unstable_greptime/`)
```
GT_FUZZ_INSTANCE_ROOT_DIR = /path/to/
```



WenyXu marked this conversation as resolved.
Show resolved Hide resolved
## Run
1. List all fuzz targets
```bash
Expand Down
23 changes: 23 additions & 0 deletions tests-fuzz/conf/standalone.template.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
mode = 'standalone'
enable_memory_catalog = false
require_lease_before_startup = true

[wal]
provider = "raft_engine"
file_size = '1GB'
purge_interval = '10m'
purge_threshold = '10GB'
read_batch_size = 128
sync_write = false

[storage]
type = 'File'
data_home = '{data_home}'

[grpc_options]
addr = '127.0.0.1:4001'
runtime_size = 8

[procedure]
max_retry_times = 3
retry_delay = "500ms"
37 changes: 37 additions & 0 deletions tests-fuzz/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,31 @@ use common_macro::stack_trace_debug;
use snafu::{Location, Snafu};

use crate::ir::create_expr::{CreateDatabaseExprBuilderError, CreateTableExprBuilderError};
#[cfg(feature = "unstable")]
use crate::utils::process::Pid;

pub type Result<T> = std::result::Result<T, Error>;

#[derive(Snafu)]
#[snafu(visibility(pub))]
#[stack_trace_debug]
pub enum Error {
#[snafu(display("Failed to create a file: {}", path))]
CreateFile {
path: String,
location: Location,
#[snafu(source)]
error: std::io::Error,
},

#[snafu(display("Failed to write a file: {}", path))]
WriteFile {
path: String,
location: Location,
#[snafu(source)]
error: std::io::Error,
},

#[snafu(display("Unexpected, violated: {violated}"))]
Unexpected {
violated: String,
Expand Down Expand Up @@ -56,4 +74,23 @@ pub enum Error {

#[snafu(display("Failed to assert: {}", reason))]
Assert { reason: String, location: Location },

#[snafu(display("Child process exited unexpected"))]
UnexpectedExited { location: Location },

#[snafu(display("Failed to spawn a child process"))]
SpawnChild {
location: Location,
#[snafu(source)]
error: std::io::Error,
},

#[cfg(feature = "unstable")]
#[snafu(display("Failed to kill a process, pid: {}", pid))]
KillProcess {
location: Location,
#[snafu(source)]
error: nix::Error,
pid: Pid,
},
}
47 changes: 45 additions & 2 deletions tests-fuzz/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,31 +12,74 @@
// See the License for the specific language governing permissions and
// limitations under the License.

pub mod config;
pub mod health;
#[cfg(feature = "unstable")]
pub mod process;

use std::env;

use common_telemetry::info;
use sqlx::mysql::MySqlPoolOptions;
use sqlx::{MySql, Pool};

/// Database connections
pub struct Connections {
pub mysql: Option<Pool<MySql>>,
}

const GT_MYSQL_ADDR: &str = "GT_MYSQL_ADDR";

pub async fn init_greptime_connections() -> Connections {
/// Connects to GreptimeDB via env variables.
pub async fn init_greptime_connections_via_env() -> Connections {
let _ = dotenv::dotenv();
let mysql = if let Ok(addr) = env::var(GT_MYSQL_ADDR) {
Some(addr)
} else {
info!("GT_MYSQL_ADDR is empty, ignores test");
None
};

init_greptime_connections(mysql).await
}

/// Connects to GreptimeDB via env variables.
WenyXu marked this conversation as resolved.
Show resolved Hide resolved
pub async fn init_greptime_connections(mysql: Option<String>) -> Connections {
let mysql = if let Some(addr) = mysql {
Some(
MySqlPoolOptions::new()
.connect(&format!("mysql://{addr}/public"))
.await
.unwrap(),
)
} else {
info!("GT_MYSQL_ADDR is empty, ignores test");
None
};

Connections { mysql }
}

const GT_FUZZ_BINARY_PATH: &str = "GT_FUZZ_BINARY_PATH";
const GT_FUZZ_INSTANCE_ROOT_DIR: &str = "GT_FUZZ_INSTANCE_ROOT_DIR";

/// The variables for unstable test
pub struct UnstableTestVariables {
pub binary_path: String,
pub root_dir: Option<String>,
}

/// Loads env variables for unstable test
pub fn load_unstable_test_env_variables() -> UnstableTestVariables {
let _ = dotenv::dotenv();
let binary_path = env::var(GT_FUZZ_BINARY_PATH).expect("GT_FUZZ_BINARY_PATH not found");
let root_dir = if let Ok(root) = env::var(GT_FUZZ_INSTANCE_ROOT_DIR) {
Some(root)
} else {
None
};

UnstableTestVariables {
binary_path,
root_dir,
}
}
57 changes: 57 additions & 0 deletions tests-fuzz/src/utils/config.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
// Copyright 2023 Greptime Team
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

use std::path::PathBuf;

use common_telemetry::tracing::info;
use serde::Serialize;
use snafu::ResultExt;
use tinytemplate::TinyTemplate;
use tokio::fs::File;
use tokio::io::AsyncWriteExt;

use crate::error;
use crate::error::Result;

/// Get the path of config dir `tests-fuzz/conf`.
pub fn get_conf_path() -> PathBuf {
let mut root_path = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
root_path.push("conf");
root_path
}

/// Returns rendered config file.
pub fn render_config_file<C: Serialize>(template_path: &str, context: &C) -> String {
let mut tt = TinyTemplate::new();
let template = std::fs::read_to_string(template_path).unwrap();
tt.add_template(template_path, &template).unwrap();
tt.render(template_path, context).unwrap()
}

pub async fn write_config_file<C: Serialize>(
WenyXu marked this conversation as resolved.
Show resolved Hide resolved
template_path: &str,
context: &C,
output_path: &str,
) -> Result<()> {
info!("template_path: {template_path}, output_path: {output_path}");
let content = render_config_file(template_path, context);
let mut config_file = File::create(output_path)
.await
.context(error::CreateFileSnafu { path: output_path })?;
config_file
.write_all(content.as_bytes())
.await
.context(error::WriteFileSnafu { path: output_path })?;
Ok(())
}
Loading
Loading