build: only build amd64 image for CentOS

[evenyag]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

briansmith/ring#1728

What's changed and what's your intention?

https://github.com/GreptimeTeam/greptimedb/actions/runs/8778537946/job/24085145007

While building dev builder image on CentOS we got the following error

error: failed to run custom build command for `ring v0.17.8`

cargo:warning=include/ring-core/arm_arch.h:82:2: error: #error "ARM assembler must define __ARM_ARCH"

#22 163.9   cargo:warning=ToolExecError: Command "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-I" "include" "-I" "/tmp/cargo-installlVctJw/release/build/ring-d3e8df3d499b101a/out" "-Wall" "-Wextra" "-fvisibility=hidden" "-std=c1x" "-Wall" "-Wbad-function-cast" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wnested-externs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wstrict-prototypes" "-Wundef" "-Wuninitialized" "-g3" "-DNDEBUG" "-o" "/tmp/cargo-installlVctJw/release/build/ring-d3e8df3d499b101a/out/ca5a6bd8bd60c5f6-chacha-armv8-linux64.o" "-c" "/root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ring-0.17.8/pregenerated/chacha-armv8-linux64.S" with args "cc" did not execute successfully (status code exit status: 1).cargo:warning=In file included from /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ring-0.17.8/pregenerated/chacha20_poly1305_armv8-linux64.S:4:0:
#22 163.9   cargo:warning=include/ring-core/asm_base.h:73:2: error: #error "ARM assembler must define __ARM_ARCH"
#22 163.9   cargo:warning= #error "ARM assembler must define __ARM_ARCH"
#22 163.9   cargo:warning=  ^
#22 163.9   cargo:warning=In file included from /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ring-0.17.8/pregenerated/chacha20_poly1305_armv8-linux64.S:7:0:
#22 163.9   cargo:warning=include/ring-core/arm_arch.h:82:2: error: #error "ARM assembler must define __ARM_ARCH"
#22 163.9   cargo:warning= #error "ARM assembler must define __ARM_ARCH"
#22 163.9   cargo:warning=  ^
#22 163.9 
#22 163.9   exit status: 1

Version 0.17 of ring doesn't support CentOS arm64. Since we don't provide arm64 binary for CentOS, I removed the arm64 image for CentOS in this PR.

BUILDX_MULTI_PLATFORM_BUILD now has three possible value

• all: builds images for both amd64 and arm64 platform
• amd64: builds amd64 image only
• false: builds image for current platform

Checklist

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR does not require documentation updates.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.27%. Comparing base (924c52a) to head (4cbd9df).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3784      +/-   ##
==========================================
- Coverage   85.59%   85.27%   -0.33%     
==========================================
  Files         946      946              
  Lines      159955   159955              
==========================================
- Hits       136921   136402     -519     
- Misses      23034    23553     +519     

[killme2008]

LGTM

[tisonkun]

To be clear, once ring supports Linux arm64 again, we'd revert this change? Or we just no longer provide arm64 image.

[evenyag]

To be clear, once ring supports Linux arm64 again, we'd revert this change? Or we just no longer provide arm64 image.

ring supports arm64, but not on CentOS 7 arm64. We also have other issues while compiling on CentOS 7 arm64 so we only provide binary for CentOS 7 x64.

[tisonkun]

Make sense. CentOS 7 will be end of life at June 30, 2024. I suppose we provide such an image for certain user cases, and thus if no users need CentOS 7 arm64 explicitly, we can provide only CentOS 7 x64.

[evenyag]

I suppose we provide such an image for certain user cases, and thus if no users need CentOS 7 arm64 explicitly, we can provide only CentOS 7 x64.

It only builds an image for compiling the database (dev-builder), not for serving the database. We didn't use that image in the release action.

So this PR fixes an unexpected behavior.