-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support tracing rule sampler #3405
Merged
waynexia
merged 2 commits into
GreptimeTeam:main
from
Taylor-lagrange:feat-trace-sampler
Mar 5, 2024
Merged
feat: support tracing rule sampler #3405
waynexia
merged 2 commits into
GreptimeTeam:main
from
Taylor-lagrange:feat-trace-sampler
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taylor-lagrange
force-pushed
the
feat-trace-sampler
branch
from
February 28, 2024 08:27
ebb105f
to
38cca10
Compare
github-actions
bot
added
docs-required
This change requires docs update.
and removed
docs-required
This change requires docs update.
labels
Feb 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3405 +/- ##
==========================================
- Coverage 85.74% 84.50% -1.25%
==========================================
Files 893 900 +7
Lines 147207 148511 +1304
==========================================
- Hits 126222 125497 -725
- Misses 20985 23014 +2029 |
MichaelScofield
approved these changes
Mar 4, 2024
zhongzc
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Implement a tracing sampler, the sampling rate of tracing can be determined based on different protocol and request_types of the protocol.
Current support
protocol
andrequest_types
:User can config the tracing sampler rule by config like
The matching principle is to match rules one by one, and use the first match rule as the sampling rate. If no rules hit, the default ratio is used as the sampling rate.
At the entrance of each protocol&request_type, the corresponding fields are marked. The sampler matches these fields by rules, and finally determines the sampling rate of a certain protocol&request_type.
Checklist
Refer to a related PR or issue link (optional)