-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configuration for tls watch option #3395
feat: add configuration for tls watch option #3395
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3395 +/- ##
==========================================
- Coverage 85.68% 84.54% -1.14%
==========================================
Files 893 899 +6
Lines 147382 148982 +1600
==========================================
- Hits 126285 125959 -326
- Misses 21097 23023 +1926 |
Ignore the coverage error because this patch is mainly for test and doesn't introduce anything big. It might be a coverage error I think. |
Exactly why I don't like Codecov 🤣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment on naming.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This patch adds configuration item
watch
toTlsOption
to control notify behaviour.part 2 of #3335 , Fixes #3255
Checklist
Refer to a related PR or issue link (optional)