feat: distinguish between different read paths #3369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR handles different
read
/freeze
paths ofDataBuffer
in different components π΅βπ«For
DataBuffer::read
insideShardBuilder
pk_weights
must be present, yielded rows are sorted according to weightsreplace_pk_index
set to false as pk dict are not frozen yetkeep_data
set to trueFor
DataBuffer::freeze
insideShardBuilder
pk_weights
must be present, yielded rows are sorted according to weightsreplace_pk_index
set to true so that yieldedDataPart
contains only weightskeep_data
set to false as we need to take the valuesFor
DataBuffer::read
insideShard
pk_weights
set to None as DataBuffer in Shard has already replaced pk_index with weights, rows are sorted by "pk_index" directlyreplace_pk_index
set to false for the same reasonkeep_data
set to trueFor
DataBuffer::freeze
insideShard
pk_weights
set to None as DataBuffer in Shard has already replaced pk_index with weights, rows are sorted by "pk_index" directlyreplace_pk_index
set to false for the same reasonkeep_data
set to false as we need to take the valuesChecklist
Refer to a related PR or issue link (optional)