Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip filling NULL for put and delete requests #3364

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

As the title. Test result:

  • Cut put latency by half

image

  • Double put throughput (18w to 42w)
Before After
image image
  • No regression in TSBS (and somehow has a little improvement...)

Before

Summary:
loaded 1036800000 metrics in 190.468sec with 6 workers (mean rate 5443439.71 metrics/sec)
loaded 103680000 rows in 190.468sec with 6 workers (mean rate 544343.97 rows/sec)

After

Summary:
loaded 1036800000 metrics in 187.196sec with 6 workers (mean rate 5538568.26 metrics/sec)
loaded 103680000 rows in 187.196sec with 6 workers (mean rate 553856.83 rows/sec)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@waynexia waynexia added the C-performance Category Performance label Feb 22, 2024
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 22, 2024
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia enabled auto-merge February 22, 2024 12:18
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1dc4fec) 85.43% compared to head (855847c) 84.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3364      +/-   ##
==========================================
- Coverage   85.43%   84.98%   -0.46%     
==========================================
  Files         889      889              
  Lines      145471   145458      -13     
==========================================
- Hits       124288   123621     -667     
- Misses      21183    21837     +654     

Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@waynexia waynexia added this pull request to the merge queue Feb 22, 2024
Merged via the queue into GreptimeTeam:main with commit 7341f23 Feb 22, 2024
22 checks passed
@waynexia waynexia deleted the skip-filling-null branch February 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-performance Category Performance docs-not-required This change does not impact docs.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants